Skip to content

Add Locators for cross-linking apps and management sections#155105

Closed
tsullivan wants to merge 33 commits intoelastic:mainfrom
tsullivan:locators/app-integrations
Closed

Add Locators for cross-linking apps and management sections#155105
tsullivan wants to merge 33 commits intoelastic:mainfrom
tsullivan:locators/app-integrations

Conversation

@tsullivan
Copy link
Copy Markdown
Member

@tsullivan tsullivan commented Apr 18, 2023

Summary

Needed for #152510

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan changed the title Locators/app integrations Add Locators for cross-linking apps and management sections Apr 18, 2023
@tsullivan tsullivan added the Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// label Apr 18, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 19, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / ML locator AnomalyDetection should throw an error in case the page is not provided

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 615 616 +1
crossClusterReplication 147 148 +1
fleet 798 799 +1
grokdebugger 36 38 +2
indexManagement 489 490 +1
logstash 62 64 +2
ml 1728 1729 +1
osquery 265 266 +1
painlessLab 32 33 +1
reporting 90 91 +1
rollup 143 144 +1
security 499 500 +1
spaces 259 260 +1
transform 318 319 +1
triggersActionsUi 554 556 +2
upgradeAssistant 138 139 +1
watcher 186 188 +2
total +21

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
rollup 21 22 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
crossClusterReplication 168.2KB 168.1KB -36.0B
fleet 945.5KB 945.5KB +25.0B
grokdebugger 59.1KB 59.1KB -34.0B
indexManagement 526.0KB 525.2KB -797.0B
logstash 33.1KB 33.1KB +1.0B
rollup 131.2KB 131.2KB -37.0B
security 557.3KB 557.3KB -3.0B
transform 376.3KB 376.3KB -42.0B
triggersActionsUi 1.4MB 1.4MB +17.0B
total -906.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ml 40 41 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 165.5KB 165.9KB +431.0B
crossClusterReplication 11.9KB 12.4KB +430.0B
dashboard 26.9KB 27.0KB +19.0B
fleet 126.7KB 127.3KB +574.0B
grokdebugger 4.5KB 4.9KB +365.0B
indexLifecycleManagement 27.0KB 27.0KB +17.0B
indexManagement 27.1KB 30.4KB +3.2KB
licenseManagement 10.9KB 10.8KB -34.0B
logstash 14.0KB 14.8KB +828.0B
ml 79.6KB 80.2KB +559.0B
osquery 50.3KB 50.6KB +277.0B
painlessLab 10.3KB 10.7KB +414.0B
remoteClusters 7.8KB 7.8KB -1.0B
reporting 42.7KB 43.1KB +410.0B
rollup 11.6KB 12.0KB +449.0B
security 60.8KB 61.3KB +566.0B
snapshotRestore 27.5KB 27.4KB -16.0B
spaces 22.8KB 23.2KB +411.0B
transform 17.7KB 18.2KB +461.0B
triggersActionsUi 84.1KB 84.9KB +782.0B
upgradeAssistant 19.4KB 19.9KB +447.0B
watcher 13.4KB 13.9KB +435.0B
total +10.9KB
Unknown metric groups

API count

id before after diff
rollup 21 22 +1

ESLint disabled in files

id before after diff
fleet 10 11 +1
triggersActionsUi 6 7 +1
total +2

ESLint disabled line counts

id before after diff
cases 57 58 +1
crossClusterReplication 8 9 +1
fleet 49 51 +2
grokdebugger 1 2 +1
indexManagement 16 17 +1
logstash 0 1 +1
osquery 108 109 +1
painlessLab 1 2 +1
reporting 4 5 +1
rollup 6 7 +1
securitySolution 432 435 +3
spaces 1 2 +1
transform 32 33 +1
triggersActionsUi 118 120 +2
upgradeAssistant 9 10 +1
watcher 3 4 +1
total +20

Total ESLint disabled count

id before after diff
cases 75 76 +1
crossClusterReplication 10 11 +1
fleet 59 62 +3
grokdebugger 1 2 +1
indexManagement 20 21 +1
logstash 0 1 +1
osquery 109 110 +1
painlessLab 1 2 +1
reporting 4 5 +1
rollup 6 7 +1
securitySolution 512 515 +3
spaces 1 2 +1
transform 35 36 +1
triggersActionsUi 124 127 +3
upgradeAssistant 9 10 +1
watcher 3 4 +1
total +22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Copy Markdown
Member Author

closing this since we're pausing on investing in locators for shared ux side nav

@tsullivan tsullivan closed this Apr 21, 2023
@tsullivan tsullivan deleted the locators/app-integrations branch November 21, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants