-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Security Solution][Endpoint] Show consistent Endpoint Agent Status across security solution #154961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
paul-tavares
merged 37 commits into
elastic:main
from
paul-tavares:task/olm-6308-add-new-response-actions-to-pending-actions
Apr 19, 2023
Merged
[Security Solution][Endpoint] Show consistent Endpoint Agent Status across security solution #154961
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
b7807c5
Const of Response actions API names to console command names
paul-tavares 152b14a
refactor of EndpointAgentAndIsolationStatus component to handle all p…
paul-tavares b952023
moved `EndpointAgentAndIsolationStatus` component to `public/common/c…
paul-tavares 9e08ccc
Fix pending actions flashing
paul-tavares 8052443
Renamed `EndpointAgentAndIsolationStatus` to `EndpointAgentStatus`
paul-tavares beb8994
Replace host agent status in Agent list and details with new common a…
paul-tavares 65760ce
Refactored Host Details to use new `<EndpointAgentStatus>`
paul-tavares c1c2d61
new `<EndpointAgentStatusById/>` component
paul-tavares b13126d
Updated timeline alert details to use `<EndpointAgentStatusById/>` co…
paul-tavares 473c0f0
Delete `<AgentStatus>` component
paul-tavares 80a4ec1
Delete `<EndpointHostIsolationStatus>` - no longer needed
paul-tavares e735c29
fix exports from `endpoint_agent_status`
paul-tavares 68398c5
Updated test plan
paul-tavares adca9b3
Types: enhanced `pending_actions` to show known response actions ++ c…
paul-tavares c4add35
Test setup + initial set of tests for EndpointAgentStatus
paul-tavares 905a19a
adjust type for EndpointPendingAction
paul-tavares ced8443
Remainder tests for EndpointAgentStatus
paul-tavares 6939a71
some adjustments to tests
paul-tavares ac5cc59
Updated i18n translations
paul-tavares 3f3293c
Added `generateHostInfo()` method to `EndpointMetadataGenerator`
paul-tavares 177ae8b
Fix failing Host panel test
paul-tavares eaa7ea8
Fix failing test for host overview
paul-tavares 86e3bd4
Fix test for responder header host component
paul-tavares 0ac70c4
Fix endpoint list test by using correct data-test-subj
paul-tavares 3425169
Fix types
paul-tavares 16a20c8
Merge remote-tracking branch 'upstream/main' into task/olm-6308-add-n…
paul-tavares 4947767
Delete unused selector and fix invalid type
paul-tavares 44b2250
Sort pending action asc
paul-tavares 7fba9ae
adjust logic for display of isolation state
paul-tavares 5fcf556
Merge remote-tracking branch 'upstream/main' into task/olm-6308-add-n…
paul-tavares ff88091
fix responder test
paul-tavares becc156
feedback from ash
paul-tavares 75d263d
Merge remote-tracking branch 'upstream/main' into task/olm-6308-add-n…
paul-tavares 4800d1d
Add `pendingActions` as optional prop to EndpointAgentStatus
paul-tavares 9d284bf
Changed Endpoint list to pass along pending actions to EndpointAgentS…
paul-tavares 64e4549
change Endpoint Details to pass along pending actions to EndpointAgen…
paul-tavares 64012d4
Merge remote-tracking branch 'upstream/main' into task/olm-6308-add-n…
paul-tavares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 0 additions & 100 deletions
100
...security_solution/public/common/components/endpoint/agent_pending_action_status_badge.tsx
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
x-pack/plugins/security_solution/public/common/components/endpoint/agent_status.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also use lodash
zipObjecthere e.g.Object.freeze(zipObject(RESPONSE_ACTION_API_COMMANDS_NAMES, CONSOLE_RESPONSE_ACTION_COMMANDS)). We'd need to ensure that the values in those two consts (RESPONSE_ACTION_API_COMMANDS_NAMESandCONSOLE_RESPONSE_ACTION_COMMANDS) are in the same order if you decide to use zipObject. Perhaps with comments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had not known about that lodash function. I kind of prefer this here only because it's its clearer what the values are and I don['t have to worry about the ordering of items in the arrays.