-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Cases] Attach lens visualizations from dashboards #154918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
cd8a1b0
register addToNewCase lens action
angorayc ea900ad
update app id
angorayc fe89da7
move to cases plugin
angorayc 9ddfb2c
add cases context
angorayc f6c7b30
revert change
angorayc cebc21e
open flyout
angorayc 16a0dc7
add to existing case
angorayc f381a43
add to existing case
angorayc 2524a71
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine c79477f
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 202a037
Merge branch 'main' into lens-actions
cnasikas 564709f
Use internal cases components to show the flyout
cnasikas 1e335e2
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine d21d00f
add to existing case
angorayc fc294cb
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
angorayc 43cbb98
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 938a94e
add to existing case
angorayc 9d495c4
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
angorayc 89e0e1d
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine f2a1b24
update owner
angorayc f180907
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
angorayc 709672d
Switch to hooks
cnasikas a2e6c43
Pass storage to the KibanaContext
cnasikas dc9179e
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 2b2d93a
Wrap actions with router
cnasikas 60fc53e
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
cnasikas a1c2f4c
Merge branch 'main' of github.com:elastic/kibana into lens-actions
angorayc 21b0702
create cases from existing case modal
angorayc a518515
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 4566eea
unit tests
angorayc 84192a4
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
angorayc cda3b4e
clean up
angorayc bc5db5b
clean up
angorayc 9f60eb9
Merge branch 'main' into lens-actions
angorayc dd901cb
create case
angorayc 4427622
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
angorayc dc5b953
fixup
angorayc 8e201dc
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine dd908a8
fixup
angorayc 4b84fde
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
angorayc 0a25f2a
fixup
angorayc 9e5dc76
fixup
angorayc 1a211ca
fix add to existing case twitch
angorayc c3694df
unit tests
angorayc 8f66588
unit tests
angorayc e15d635
Fix issue with owner
cnasikas bfa8c6d
Merge branch 'main' into lens-actions
cnasikas 876cc23
review
angorayc e9fbd42
Increase limits
cnasikas 4e6dd86
Fix issue with permissions
cnasikas e1e671c
add unit tests and fix create case from cases page
angorayc b870216
Merge branch 'main' into lens-actions
angorayc f7fb35f
Merge branch 'main' into lens-actions
cnasikas 4f5290d
Use dark mode from user profile
cnasikas a40a244
Merge branch 'lens-actions' of github.com:angorayc/kibana into lens-a…
cnasikas 0a66940
Add tests
cnasikas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
x-pack/plugins/cases/public/components/visualizations/actions/__mocks__/action_wrapper.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| export const ActionWrapper = jest | ||
| .fn() | ||
| .mockImplementation(({ children }) => <div data-test-subj="action-wrapper">{children}</div>); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find a way to reduce the bundle size. The imports from
@kbn/embeddable-plugin/publicand@kbn/ui-actions-plugin/publicincreased it. I tried to import only what we need by setting the path of the import to the folder we need but I got this errorModule not found: Error: import [@kbn/embeddable-plugin/public/lib/embeddables/error_embeddable references a non-public export of the [embeddable] bundle and must point to one of the public directories: [public,common].This PR #157492 will reduce the limit substantially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Thanks for looking into it.