[Fleet] Enable agent policy "Host name format" selector by default#154563
Merged
hop-dev merged 2 commits intoelastic:mainfrom Apr 6, 2023
Merged
[Fleet] Enable agent policy "Host name format" selector by default#154563hop-dev merged 2 commits intoelastic:mainfrom
hop-dev merged 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
hop-dev
added
release_note:enhancement
Team:Fleet
hop-dev
changed the title
hop-dev
commented
Apr 6, 2023
| @@ -558,93 +557,91 @@ export const AgentPolicyAdvancedOptionsContent: React.FunctionComponent<Props> = | |||
| /> | |||
| </EuiFormRow> | |||
| </EuiDescribedFormGroup> | |||
Contributor
Author
There was a problem hiding this comment.
best viewed with "hide whitespace" I've just removed the conditional render of the component here
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
jlind23
approved these changes
Apr 6, 2023
hop-dev
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @hop-dev |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
hop-dev
added a commit
to hop-dev/kibana
that referenced
this pull request
Apr 6, 2023
…ture flag references (elastic#154563) ## Summary This pull request enables the feature flag which hid the host name format selector in agent policies. The host name selector can be used in any agent policy, go to the agent policy settings tab then scroll to the bottom. Feature flag was disabled by default in elastic#152592 Enabling the feature flag by default also means we can remove references to it in the code now. (we keep the flag reference so that nobodies config is invalidated) **Before:** <img width="896" alt="Screenshot 2023-04-06 at 15 34 57" src="https://user-images.githubusercontent.com/3315046/230411132-364a1b21-3007-4f20-af25-5e6208786120.png"> **After:** <img width="925" alt="Screenshot 2023-04-06 at 15 31 53" src="https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png"> (cherry picked from commit b9d38be) # Conflicts: # x-pack/plugins/fleet/common/experimental_features.ts
hop-dev
added a commit
that referenced
this pull request
Apr 6, 2023
…DN feature flag references (#154563) (#154592) # Backport This will backport the following commits from `main` to `8.7`: - [[Fleet] Enable Host name format selector by default + remove FQDN feature flag references (#154563)](#154563) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2023-04-06T15:31:29Z","message":"[Fleet] Enable Host name format selector by default + remove FQDN feature flag references (#154563)\n\n## Summary\r\n\r\nThis pull request enables the feature flag which hid the host name\r\nformat selector in agent policies.\r\n\r\nThe host name selector can be used in any agent policy, go to the agent\r\npolicy settings tab then scroll to the bottom.\r\n\r\nFeature flag was disabled by default in\r\nhttps://github.com//pull/152592\r\n\r\nEnabling the feature flag by default also means we can remove references\r\nto it in the code now. (we keep the flag reference so that nobodies\r\nconfig is invalidated)\r\n\r\n**Before:**\r\n<img width=\"896\" alt=\"Screenshot 2023-04-06 at 15 34 57\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/230411132-364a1b21-3007-4f20-af25-5e6208786120.png\">\r\n\r\n**After:**\r\n<img width=\"925\" alt=\"Screenshot 2023-04-06 at 15 31 53\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","v8.8.0","v8.7.1"],"number":154563,"url":"https://github.com/elastic/kibana/pull/154563","mergeCommit":{"message":"[Fleet] Enable Host name format selector by default + remove FQDN feature flag references (#154563)\n\n## Summary\r\n\r\nThis pull request enables the feature flag which hid the host name\r\nformat selector in agent policies.\r\n\r\nThe host name selector can be used in any agent policy, go to the agent\r\npolicy settings tab then scroll to the bottom.\r\n\r\nFeature flag was disabled by default in\r\nhttps://github.com//pull/152592\r\n\r\nEnabling the feature flag by default also means we can remove references\r\nto it in the code now. (we keep the flag reference so that nobodies\r\nconfig is invalidated)\r\n\r\n**Before:**\r\n<img width=\"896\" alt=\"Screenshot 2023-04-06 at 15 34 57\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/230411132-364a1b21-3007-4f20-af25-5e6208786120.png\">\r\n\r\n**After:**\r\n<img width=\"925\" alt=\"Screenshot 2023-04-06 at 15 31 53\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154563","number":154563,"mergeCommit":{"message":"[Fleet] Enable Host name format selector by default + remove FQDN feature flag references (#154563)\n\n## Summary\r\n\r\nThis pull request enables the feature flag which hid the host name\r\nformat selector in agent policies.\r\n\r\nThe host name selector can be used in any agent policy, go to the agent\r\npolicy settings tab then scroll to the bottom.\r\n\r\nFeature flag was disabled by default in\r\nhttps://github.com//pull/152592\r\n\r\nEnabling the feature flag by default also means we can remove references\r\nto it in the code now. (we keep the flag reference so that nobodies\r\nconfig is invalidated)\r\n\r\n**Before:**\r\n<img width=\"896\" alt=\"Screenshot 2023-04-06 at 15 34 57\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/230411132-364a1b21-3007-4f20-af25-5e6208786120.png\">\r\n\r\n**After:**\r\n<img width=\"925\" alt=\"Screenshot 2023-04-06 at 15 31 53\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
![https://user-images.githubusercontent.com/3315046/230411132-364a1b21-3007-4f20-af25-5e6208786120.png\">\r\n\r\n**After:**\r\n<img](https://user-images.githubusercontent.com/3315046/230411132-364a1b21-3007-4f20-af25-5e6208786120.png\">\r\n\r\n**After:**\r\n<img){kind=link}
![https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","v8.8.0","v8.7.1"],"number":154563,"url":"https://github.com/elastic/kibana/pull/154563","mergeCommit":{"message":"[Fleet]](https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","v8.8.0","v8.7.1"],"number":154563,"url":"https://github.com/elastic/kibana/pull/154563","mergeCommit":{"message":"[Fleet]){kind=link}
![https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154563","number":154563,"mergeCommit":{"message":"[Fleet]](https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154563","number":154563,"mergeCommit":{"message":"[Fleet]){kind=link}
![https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED](https://user-images.githubusercontent.com/3315046/230410428-879dc975-fb27-434e-bc91-d43185361b71.png\">","sha":"b9d38be8e28a0855662b84cbcb814484728a2f3e"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enables the feature flag which hid the host name format selector in agent policies.
The host name selector can be used in any agent policy, go to the agent policy settings tab then scroll to the bottom.
Feature flag was disabled by default in #152592
Enabling the feature flag by default also means we can remove references to it in the code now. (we keep the flag reference so that nobodies config is invalidated)
Before:
After:
