-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Remove the name field from the security-rule SO mappings #154473
[Security Solution] Remove the name field from the security-rule SO mappings #154473
Conversation
23fa2d0
to
f795b8d
Compare
f795b8d
to
5f84262
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Saved Objects .kibana field count
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @banderror |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to: https://github.com/elastic/security-team/issues/6268 (internal)
Summary
For each of our Saved Object types, we must:
index: false
(orenabled: false
, although a first pass was done in Cleanupenabled: false
saved objects mappings #149102) from our SOmappings
declarationsThis PR addresses these two requirements for this
security-rule
saved object type (prebuilt rule asset).Details
Specifically, the PR removes the
name
field from the mappings because:Also, we may need to add more fields to this mapping in the future to implement further improvements for the prebuilt rule installation, upgrade, or deprecation workflows.
Checklist