[Lens] Improve Ignore global filters UI by dej611 · Pull Request #154441 · elastic/kibana

dej611 · 2023-04-05T10:44:20Z

Summary

This PR revisits partially the Layer Settings UI in order to support the Data and Appereance split in the UI and enhance the ignore global filters UI to make it clearer for the user the state of this setting.

when the setting is disabled (to use global filters) then nothing is shown:

On Annotations layer that is the only available setting:

The new refactoring can now handle multiple settings for each panel section as shown in the Partition charts settings panel:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2023-04-13T09:23:22Z

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

stratoula

Except from the typo changes LGTM, I tested locally in Chrome and works fine. I am approving to not block this PR!

stratoula · 2023-04-18T06:30:16Z

x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx

                    ...layerVisualizationConfigProps,
                    setState: props.updateVisualization,
                    panelRef: settingsPanelRef,
+                    section: 'appereance',


This has a typo

What's the typo?

It should be appearance no ?

stratoula · 2023-04-18T06:30:36Z

x-pack/plugins/lens/public/visualizations/partition/layer_settings.test.tsx

    const layerId = 'layer-id';
-    const props: VisualizationLayerSettingsProps<PieVisualizationState> = {
+    const props: VisualizationLayerSettingsProps<PieVisualizationState> & {
+      section: 'data' | 'appereance';


Also here :D

stratoula · 2023-04-18T06:30:48Z

x-pack/plugins/lens/public/visualizations/partition/layer_settings.tsx

+export function LayerSettings(
+  props: VisualizationLayerSettingsProps<PieVisualizationState> & { section: 'data' | 'appereance' }
+) {
+  if (props.section === 'appereance') {


kibana-ci · 2023-04-18T09:08:03Z

💚 Build Succeeded

Buildkite Build
Commit: c7a9c09

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	907	908	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.3MB	1.3MB	+1.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`lens`	53	52	-1

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	432	435	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	512	515	+3

History

💚 Build #120526 succeeded 7daeab8
💛 Build #120175 was flaky e1d5ac7
💚 Build #119671 succeeded 6b04133
💔 Build #119478 failed 0db73aa
💔 Build #117970 failed 11573f3
💔 Build #117955 failed 5ad079d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

## Summary Adds the 8.8 documentation for the following: - Enable report sharing: #153429 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/reporting-getting-started.html - Random sampling feature: #143221 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#improve-visualization-loading-time - Improve Ignore global filters UI: #154441 and #155280 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations --------- Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

## Summary Adds the 8.8 documentation for the following: - Enable report sharing: elastic#153429 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/reporting-getting-started.html - Random sampling feature: elastic#143221 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#improve-visualization-loading-time - Improve Ignore global filters UI: elastic#154441 and elastic#155280 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations --------- Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> (cherry picked from commit 06a800f)

# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Adds 8.8 Viz docs (#157215)](#157215)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

## Summary Adds the 8.8 documentation for the following: - Enable report sharing: elastic#153429 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/reporting-getting-started.html - Random sampling feature: elastic#143221 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#improve-visualization-loading-time - Improve Ignore global filters UI: elastic#154441 and elastic#155280 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations --------- Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

✨ Reworked ignore global fitlers UI

4fb4f9a

dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.8.0 labels Apr 5, 2023

dej611 added 5 commits April 5, 2023 13:59

🔥 remove unused translations

5ad079d

✅ Add test for appereance section

11573f3

Merge remote-tracking branch 'upstream/main' into feature/154316

e742ac6

✅ Fix test ids for functional checks

0db73aa

♻️ Refactor to let trigger have its own test id

6b04133

dej611 marked this pull request as ready for review April 13, 2023 09:23

dej611 requested a review from a team as a code owner April 13, 2023 09:23

dej611 and others added 3 commits April 17, 2023 10:21

Merge branch 'main' into feature/154316

558bbcd

Merge branch 'main' into feature/154316

e1d5ac7

Merge branch 'main' into feature/154316

7daeab8

stratoula approved these changes Apr 18, 2023

View reviewed changes

👌 Integrate feedback

c7a9c09

dej611 merged commit 779e553 into elastic:main Apr 18, 2023

kibanamachine added the backport:skip This PR does not require backporting label Apr 18, 2023

KOTungseth mentioned this pull request Apr 25, 2023

[DOCS] Add documentation for 8.8 #155793

Closed

19 tasks

KOTungseth mentioned this pull request May 9, 2023

[DOCS] Adds 8.8 Viz docs #157215

Merged

dej611 mentioned this pull request Jul 18, 2023

[Lens] Provide a way to make the user aware of the current ignoreGlobalFilters state #142383

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Improve Ignore global filters UI#154441

[Lens] Improve Ignore global filters UI#154441
dej611 merged 10 commits intoelastic:mainfrom
dej611:feature/154316

dej611 commented Apr 5, 2023

Uh oh!

elasticmachine commented Apr 13, 2023

Uh oh!

stratoula left a comment •

edited

Loading

Uh oh!

stratoula Apr 18, 2023

Uh oh!

dej611 Apr 18, 2023

Uh oh!

stratoula Apr 18, 2023

Uh oh!

stratoula Apr 18, 2023

Uh oh!

stratoula Apr 18, 2023

Uh oh!

kibana-ci commented Apr 18, 2023

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dej611 commented Apr 5, 2023

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

elasticmachine commented Apr 13, 2023

Uh oh!

stratoula left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stratoula Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

dej611 Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

stratoula Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

stratoula Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

stratoula Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Apr 18, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Public APIs missing exports

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stratoula left a comment •

edited

Loading