[6.x] [optimizer] extract plugin discovery (#14745)#15443
Merged
spalger merged 2 commits intoelastic:6.xfrom Dec 6, 2017
Merged
[6.x] [optimizer] extract plugin discovery (#14745)#15443spalger merged 2 commits intoelastic:6.xfrom
spalger merged 2 commits intoelastic:6.xfrom
Conversation
* [plugins] extract plugin discover from the kibana server * integrate plugin discovery module with server * [pluginDiscovery] fully extend config before checking enabled status * [pluginDiscovery] limit arbitrary defaults in PluginSpec * [ui/navLink] fix tests * [ui/injectedVars] fix tests * [ui/app] fix tests * [server/plugins] convert init to callPluginHook tests * [build/verifyTranslations] update verify logic * [pluginDiscovery] remove rx utils * fix i18n transaltion key name * [pluginDiscovery] do kibana version checks as a part of discovery * [pluginDiscovery/createPacksInDirectory$] clarify error handling * [eslint] fix lint errors * [uiApp/modules] ensure load order matches master * [uiBundle] use known uiExport type for providers * [uiExports] use the `home` export type * [uiExports] validate that all uiExport types are known * [timelion] remove archaic/broken bwc check * revert some stragler changes * [pluginSpecs] reformat comments * [uiBundle] rebel and use more fcb 😬 * correct comment * [server/waitForPluginsInit] describe queues var * [server/plugins] prevent multiple calls to next() by using single then() * [uiApp] remove archaic deprecation warning * [uiApp] tighten up tests * [pluginDiscovery/errors] remove $ from symbol var * [pluginDiscovery/reduceExportSpecs] update docs * [pluginDiscovery/findPluginSpecs] rightVersion -> isRightVersion * [pluginDiscovery/findPluginSpecs] fix typos * [uiApps/getById] use Map() rather than memoize * save * [savedObjects/mappings] use uiExports.savedObjectMappings * [server/mapping/indexMapping] update tests, addRootProperties method removed * [uiExports] "embeddableHandlers" -> "embeddableFactories" * [pluginDiscovery] fix pluralization of invalidVersionSpec$ * [pluginDiscover] add README * [pluginDiscovery/reduceExportSpecs] don't ignore fasly spec values, just undefined * [ui/exportTypes] use better reducer names * [ui/uiExports] add README * fix links * [pluginDiscovery/readme] expand examples * [pluginDiscovery/readme] clean up reduceExportSpecs() doc * [ui/uiExports/readme] cleanup example * [pluginDiscovery] remove needless use of lodash * [pluginDiscovery/waitForComplete] use better name * [pluginDiscovery/findPluginSpecs] use fixtures rather than core_plugins * [pluginDiscovery/stubSchema] use deafult: false * [plguinDiscovery/pluginConfig] add tests * typo * [uiExports/readme] fix link * [pluginDiscovery/packAtPath] fail with InvalidPackError if path is not a string * [pluginDiscovery/packAtPath] rely on error.code to detect missing package.json file * [pluginDiscovery/packAtPath] only attempt to get pack when observable is subscribed * [pluginDiscovery/packAtPath] add tests * [pluginDiscovery/pluginPack] move absolute path checks into fs lib * [pluginDiscovery/packsInDirectory] fix error type check * [pluginDiscovery/pluginPack/tests] share some utils * [pluginDiscovery/packsInDirectory] add tests * [pluginDiscovery/pluginPack] only cast undefined to array * [pluginDiscovery/pluginPack] add tests * [pluginDiscovery/pluginSpec/isVersionCompatible] add tests * [pluginDiscovery/InvalidPluginError] be less redundant * [pluginDiscovery/pluginSpec] verify config service is passed to isEnabled() * [pluginDiscovery/pluginSpec] add tests * fix "existent" spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports pull request #14745 to 6.x