[Control Group]: Option to toggle floating actions#153019
[Control Group]: Option to toggle floating actions#153019logeekal wants to merge 1 commit intoelastic:mainfrom
Conversation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
This is definitely an important feature! I am actually in the process of moving the hover actions to the This would definitely help in situations where, for example, the consumer only wants to give users the ability to edit controls, and not delete them - they just wouldn't register the delete hover action in their use case. To support the concept of conditional disabling, such as the "only disable delete when there is one control remaining" idea, we would have to some generic logic to the Just throwing some ideas out there - @ThomThomson interested in your thoughts 👀 This probably warrants a larger discussion, haha! |
|
@Heenawter, I think that the plugin ui actions are registered in has no bearing on where they show up. In any case, this use case of conditionally disabling actions on an embeddable is already covered by the @logeekal is it possible to wait for this feature until Hannah's PR for using If you need this feature sooner than that, could you potentially use the existing |
|
@logeekal #153065 has been merged, so you should now be able to control which actions are available via the I added an example of this to the example plugin, but let me know if you have any other questions/concerns about this approach - hopefully that works much better for ya'll :) |
|
This is awesome news @Heenawter . Thank you very much. I will try it out and will get back to you. |
Summary
This PR adds the option to toggle floating actions.
Motivation
In security solution, we have a need to disable
floating actionsselectively in some cases. For example, user can delete the controls but we want to enforce at least one control on the screen. Hence, we want to allow users to edit the control but not delete it.Screen.Recording.2023-03-09.at.15.18.36.mov