Skip to content

Revert "Upgrade vega dependency (5.22.1 → 5.23.0)."#152906

Merged
drewdaemon merged 3 commits intomainfrom
revert-152541-issue-xxx-vega-update
Mar 8, 2023
Merged

Revert "Upgrade vega dependency (5.22.1 → 5.23.0)."#152906
drewdaemon merged 3 commits intomainfrom
revert-152541-issue-xxx-vega-update

Conversation

@drewdaemon
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon commented Mar 8, 2023 •
edited by kibanamachine
Loading

@drewdaemon drewdaemon requested review from a team as code owners March 8, 2023 13:42
@drewdaemon drewdaemon added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Mar 8, 2023
stratoula
stratoula reviewed Mar 8, 2023
View reviewed changes
jbudz
jbudz reviewed Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handing off the operations review to @azasypkin.

@jbudz jbudz requested a review from azasypkin March 8, 2023 14:03
@drewdaemon
Copy link
Copy Markdown
Contributor Author

drewdaemon commented Mar 8, 2023

@jbudz — @azasypkin is out today. Could you please give this a review?

@drewdaemon
Copy link
Copy Markdown
Contributor Author

drewdaemon commented Mar 8, 2023

cc @legrego for visibility

stratoula
stratoula approved these changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I tested it locally and everything seems to work fine

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 8, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +21.1KB
visTypeVega 1.7MB 1.8MB +21.1KB
total +42.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 431 433 +2

Total ESLint disabled count

id before after diff
securitySolution 508 510 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 5ab7d46 into main Mar 8, 2023
@drewdaemon drewdaemon deleted the revert-152541-issue-xxx-vega-update branch March 8, 2023 18:02
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2023
@drewdaemon
Revert "Upgrade vega dependency (5.22.1 → 5.23.0)." (elastic#15…
a2cf325 
…2906)

(cherry picked from commit 5ab7d46)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 8, 2023

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 152906

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 8, 2023
@kibanamachine @drewdaemon
[8.7] Revert "Upgrade vega dependency (5.22.1 → 5.23.0)." (#152906
9fcd658 
) (#152946)

# Backport

This will backport the following commits from `main` to `8.7`:
- [Revert "Upgrade `vega` dependency (`5.22.1` → `5.23.0`)."
(#152906)](#152906)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2023-03-08T18:02:22Z","message":"Revert
\"Upgrade `vega` dependency (`5.22.1` → `5.23.0`).\"
(#152906)","sha":"5ab7d464f23c1b441daeeaa315815f4593025689","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.8.0"],"number":152906,"url":"https://github.com/elastic/kibana/pull/152906","mergeCommit":{"message":"Revert
\"Upgrade `vega` dependency (`5.22.1` → `5.23.0`).\"
(#152906)","sha":"5ab7d464f23c1b441daeeaa315815f4593025689"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152906","number":152906,"mergeCommit":{"message":"Revert
\"Upgrade `vega` dependency (`5.22.1` → `5.23.0`).\"
(#152906)","sha":"5ab7d464f23c1b441daeeaa315815f4593025689"}}]}]
BACKPORT-->

Co-authored-by: Drew Tate <drew.tate@elastic.co>
@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Mar 9, 2023

Automatic backport of 7.17 failed, I created one manually here #152979

bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@drewdaemon @bmorelli25
Revert "Upgrade vega dependency (5.22.1 → 5.23.0)." (elastic#15…
0f055bd 
…2906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

@stratoula stratoula stratoula approved these changes

@azasypkin azasypkin Awaiting requested review from azasypkin

Assignees

No one assigned

Labels

backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@drewdaemon @kibana-ci @kibanamachine @stratoula @jbudz