[Security Solution] expanded flyout - right section - overview tab - mitre attack#152767
Merged
PhilippeOberti merged 1 commit intomainfrom Mar 10, 2023
Merged
[Security Solution] expanded flyout - right section - overview tab - mitre attack#152767PhilippeOberti merged 1 commit intomainfrom
PhilippeOberti merged 1 commit intomainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
5219c54 to
73059de
Compare
73059de to
af32b16
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Contributor
|
I will take a look after the base one is merged:) |
Contributor
Author
the base one was merged yesterday, this PR is rebased and ready for review, I just had forgotten to update the description! |
michaelolo24
approved these changes
Mar 10, 2023
Contributor
michaelolo24
left a comment
There was a problem hiding this comment.
Nice work, getting real data in here! 🕺🏾
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR leverages the work done in a previous PR and add the Mitre Attack section under the overview tab of the Security Solution expandable flyout right section panel:
getMitreComponentPartsmethod to get the display of the mitre attack's descriptionHow to test
xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']to thekibana.jsonfileyarn es snapshot --license trial,yarn test:generateandyarn start --no-base-pathNotes
To generate alerts with Mitre Attack value, you can for example create a new
Custom Queryrule with the following_id is *query, then in the second section (About rule), expand theAdvanced Settingsthen add some tactic and technique valuesRun tests and storybook
node scripts/storybook security_solutionto run Storybooknpm run test:jest --config ./x-pack/plugins/security_solution/public/flyoutto run the unit testsyarn cypress:open-as-cibut note that the integration/e2e tests have been written but are now skipped because the feature is protected behind a feature flag, disabled by default. To check them, add'securityFlyoutEnabled'herehttps://github.com/elastic/security-team/issues/6069
Checklist
Delete any items that are not applicable to this PR.