[Synthetics] Fix filters persistance#152543

Merged

shahzad31 merged 5 commits intoelastic:mainfrom

shahzad31:fix-persis-filters

Mar 6, 2023

Contributor

shahzad31 commented Mar 2, 2023 •

edited by kibanamachine

Loading

Summary

Keep filters persistance after monitor has been edited.


          fix filters persistance

bb5fe44

shahzad31 added release_note:skip v8.7.0 v8.8.0 labels

shahzad31 marked this pull request as ready for review

March 2, 2023 08:51

shahzad31 requested a review from a team as a code owner

March 2, 2023 08:51

shahzad31 requested a review from a team

March 2, 2023 08:51

awahab07 reviewed

View reviewed changes

Contributor

awahab07 left a comment

The reported problem is resolved. ✔️

Would be nice to handle the following edge case as well where an orphan option value makes the UI in an inconsistent state.

152543-Should-remove-orphan-filter-options.mov

botelastic bot added the Team:Uptime - DEPRECATED label

Contributor

elasticmachine commented Mar 2, 2023

Pinging @elastic/uptime (Team:uptime)

shahzad31 added 2 commits

March 2, 2023 12:07


          Merge branch 'main' of github.com:elastic/kibana into fix-persis-filters

c285698


          handle edge case

8fa86ac

awahab07 approved these changes

View reviewed changes

Contributor

awahab07 left a comment

LGTM.

Works well.

shahzad31 added 2 commits

March 2, 2023 20:43


          Merge branch 'main' of github.com:elastic/kibana into fix-persis-filters

450c3ca


          update code owners

8262a87

kibana-ci commented Mar 2, 2023

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 8262a87

Failed CI Steps

Synthetics @elastic/synthetics Tests

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	1.1MB	1.1MB	+96.0B
`synthetics`	1.4MB	1.4MB	+290.0B
total			+386.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`observability`	53	54	+1
`securitySolution`	428	430	+2
total			+3

Total ESLint disabled count

id	before	after	diff
`observability`	59	60	+1
`securitySolution`	506	508	+2
total			+3

History

💚 Build #111673 succeeded 8fa86ac
💚 Build #111612 succeeded bb5fe44

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

maryam-saeidi requested changes

View reviewed changes

...ins/observability/public/components/shared/field_value_suggestions/field_value_selection.tsx

                   setOptions(formatOptions(values, selectedValue, excludedValue, showCount));
-                }, [values, selectedValue, showCount, excludedValue]);
+                  // eslint-disable-next-line react-hooks/exhaustive-deps
+                }, [JSON.stringify(values), JSON.stringify(selectedValue), showCount, excludedValue]);

Member

maryam-saeidi Mar 6, 2023

Doesn't this impact performance since it uses JSON.stringify on every render?
Can't we use useMemo in the parent component instead?

Contributor Author

shahzad31 Mar 6, 2023

i think in this specific case. it won't have any impact. Since it's only meant to be triggered on new fetch of the data.

Contributor Author

shahzad31 Mar 6, 2023

if the new fetch of the data remains same, we don't want existing component to re-render since data selection should remain same.

Contributor Author

shahzad31 Mar 6, 2023

Using useMemo won't help in parent component.

Member

maryam-saeidi Mar 6, 2023 •

edited

Loading

i think in this specific case. it won't have any impact. Since it's only meant to be triggered on new fetch of the data.

You mean FieldValueSelection only re-renders when there is new data? Where is this logic?

Using useMemo won't help in parent component.

Why is that?

Contributor Author

shahzad31 Mar 6, 2023

this is being used on auto-refresh in synthetics app. so when that happens. the new data remains same , but it will trigger useMemo re-render. this is why we are doing this deep comparison. Json.stringify impact is minimal here. since data isn't big.

maryam-saeidi approved these changes

View reviewed changes

shahzad31 merged commit 60a2c1a into elastic:main

shahzad31 deleted the fix-persis-filters branch

March 6, 2023 09:21

Contributor

kibanamachine commented Mar 6, 2023

💔 All backports failed

Status	Branch	Result
❌	8.7	Backport failed because of merge conflicts You might need to backport the following PRs to 8.7: - [Security Solution]Fix incorrect number of invalid connectors is shown on the toast message (#152313)

Manual backport

To create the backport manually run:

node scripts/backport --pr 152543

Questions ?

Please refer to the Backport tool documentation

bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request


          [Synthetics] Fix filters persistance (elastic#152543)

cd8a626

kibanamachine mentioned this pull request

[Synthetics] Filtering - location filter counts are off when filter is applied #155437

Merged

kibanamachine added the backport missing label

Contributor

kibanamachine commented Mar 31, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

3 similar comments

Contributor

kibanamachine commented Apr 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Apr 4, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Apr 5, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Apr 11, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

1 similar comment

Contributor

kibanamachine commented Apr 12, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

justinkambic added Team:obs-ux-infra_services - DEPRECATED and removed Team:Uptime - DEPRECATED labels

Contributor

elasticmachine commented Apr 15, 2024

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

justinkambic removed the v8.7.0 label

Contributor

justinkambic commented Apr 15, 2024

I've removed the 8.7 label from this PR. It seems the automated backport failed back when the PR was merged and we likely never followed up to get this backported. At this point it's unlikely we'll release another 8.7 patch, so we'll remove the label to make the bot happy.

Contributor

kibanamachine commented Apr 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

5 similar comments

Contributor

kibanamachine commented Apr 20, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Apr 22, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Jul 26, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Jul 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

Contributor

kibanamachine commented Aug 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152543 locally

maryam-saeidi added the backport:skip label

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip Team:obs-ux-infra_services - DEPRECATED v8.8.0