[Logs UI] Correctly round and update the log stream end timestamps#152387
Merged
weltenwort merged 5 commits intoelastic:mainfrom Mar 1, 2023
Merged
[Logs UI] Correctly round and update the log stream end timestamps#152387weltenwort merged 5 commits intoelastic:mainfrom
weltenwort merged 5 commits intoelastic:mainfrom
Conversation
This way it works with the visual editor.
Member
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @weltenwort |
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
tonyghiani
approved these changes
Mar 1, 2023
Contributor
tonyghiani
left a comment
There was a problem hiding this comment.
LGTM, I tested locally the scenarios I found broken and everything works fine now, thanks for taking on this so quickly 👏
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
|
The code containing the bug doesn't exist yet in 8.7, so I'll abort the backport. |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…lastic#152387) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This fixes the handling of the end timestamp in the log stream page query state machine.
closes #152363
closes #152337
🕵️♀️ Review notes
nowas the end time value.aftertransition is properly recognized by the visual editor: