Skip to content

[Logs UI] Correctly round and update the log stream end timestamps#152387

Merged
weltenwort merged 5 commits intoelastic:mainfrom
weltenwort:logs-ui-fix-time-range-end-updates
Mar 1, 2023
Merged

[Logs UI] Correctly round and update the log stream end timestamps#152387
weltenwort merged 5 commits intoelastic:mainfrom
weltenwort:logs-ui-fix-time-range-end-updates

Conversation

@weltenwort
Copy link
Copy Markdown
Member

@weltenwort weltenwort commented Feb 28, 2023

📝 Summary

This fixes the handling of the end timestamp in the log stream page query state machine.

closes #152363
closes #152337

🕵️‍♀️ Review notes

  • This fixes two problems that depend on each other:
    1. When evaluating an end time value containing date math, properly round it up.
    2. When refreshing the end timestamp upon reaching the bottom of the stream, it now preserves the time range instead of forcing a now as the end time value.
  • This also fixes the visual layout of the position state machine and moves the throttling delay to the configuration so the after transition is properly recognized by the visual editor:
    image

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services backport:prev-minor labels Feb 28, 2023
@weltenwort weltenwort self-assigned this Feb 28, 2023
@weltenwort weltenwort changed the title Round up the end timestamps [Logs UI] Correctly round and update the log stream end timestamps Feb 28, 2023
@weltenwort
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +73.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@weltenwort weltenwort marked this pull request as ready for review March 1, 2023 11:11
@weltenwort weltenwort requested a review from a team as a code owner March 1, 2023 11:11
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested locally the scenarios I found broken and everything works fine now, thanks for taking on this so quickly 👏

@weltenwort weltenwort added the release_note:skip Skip the PR/issue when compiling release notes label Mar 1, 2023
@weltenwort weltenwort merged commit ad0ddd3 into elastic:main Mar 1, 2023
@weltenwort weltenwort deleted the logs-ui-fix-time-range-end-updates branch March 1, 2023 11:26
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.7 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 152387

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Mar 1, 2023
@weltenwort
Copy link
Copy Markdown
Member Author

The code containing the bug doesn't exist yet in 8.7, so I'll abort the backport.

bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
…lastic#152387)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logs UI] Date range is not correctly updated on relative dates [Logs UI] Logs stream performs API request with wrong time

5 participants