[Synthetics] Hide location and enabled toggle on MonitorDetailsPanel for test run details#152373
Merged
shahzad31 merged 5 commits intoelastic:mainfrom Mar 1, 2023
Merged
Conversation
justinkambic
added
bug
…abled for test run details.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2023
…` for test run details (elastic#152373) Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit f23346e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2023
…sPanel` for test run details (#152373) (#152462) # Backport This will backport the following commits from `main` to `8.7`: - [[Synthetics] Hide location and enabled toggle on `MonitorDetailsPanel` for test run details (#152373)](#152373) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Justin Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2023-03-01T14:38:42Z","message":"[Synthetics] Hide location and enabled toggle on `MonitorDetailsPanel` for test run details (#152373)\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"f23346e4a61fcbce8d0678edb76a7d3055852dde","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":152373,"url":"https://github.com/elastic/kibana/pull/152373","mergeCommit":{"message":"[Synthetics] Hide location and enabled toggle on `MonitorDetailsPanel` for test run details (#152373)\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"f23346e4a61fcbce8d0678edb76a7d3055852dde"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152373","number":152373,"mergeCommit":{"message":"[Synthetics] Hide location and enabled toggle on `MonitorDetailsPanel` for test run details (#152373)\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"f23346e4a61fcbce8d0678edb76a7d3055852dde"}}]}] BACKPORT--> Co-authored-by: Justin Kambic <jk@elastic.co>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…` for test run details (elastic#152373) Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #152383.
While doing Post-FF testing for #145384, I noticed that the enabled toggle and locations are displayed on the test run details page's details description list. We don't want this here as it doesn't make any sense.
Enabled toggle was already configurable. The main reason this is happening is because we've defined a wrapper component that cannot take the necessary props to control the underlying panel. I've extracted the props and provided a
Partialinterface to the wrapper so the calling code in parent components can easily control the panel itself.I've added a
hideLocationsprop that will prevent the locations from rendering as well.I've set
hideLocationsandhideEnabledfrom the test run details component, thus fixing the issue.After
Before
Reviewing
Ensure that the enable toggle is hidden on the detail flyout, but exposed on the monitor detail page. Ensure location and enable toggle are not shown in test run details.
NOTE: this also fixes #152383. Ensure the border in the flyout is gone.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers