[Infrastructure UI] Functional tests Hosts View Alerts tab#152228
Merged
tonyghiani merged 7 commits intoelastic:mainfrom Feb 28, 2023
Merged
[Infrastructure UI] Functional tests Hosts View Alerts tab#152228tonyghiani merged 7 commits intoelastic:mainfrom
tonyghiani merged 7 commits intoelastic:mainfrom
Conversation
added 4 commits
February 23, 2023 17:11
…hiani/kibana into 150741-alerts-tab-functional-tests
tonyghiani
added
Team:Infra Monitoring UI - DEPRECATED
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
crespocarlos
approved these changes
Feb 28, 2023
Contributor
crespocarlos
left a comment
crespocarlos
left a comment
There was a problem hiding this comment.
LGTM! Thanks for all the improvements.
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…52228) ## 📓 Summary Closes elastic#150741 - Add infra alerts mock file - Add initial functional tests for the Alerts Tab - Remove duplicated tests by the role as they are inclusive of the same privileges - Restructure existing tests to **cut execution time by ~50%** Before | After :-------------------------:|:-------------------------: <img width="164" alt="before" src="https://user-images.githubusercontent.com/34506779/221805295-9de8c467-e212-4cb7-b270-bd8d10063e0f.png"> | <img width="161" alt="after" src="https://user-images.githubusercontent.com/34506779/221805315-a4a105df-6b5b-4cb4-bdeb-8384f0459f91.png"> --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #150741