Threat match tests for term query#152071
Merged
nkhristinin merged 3 commits intoelastic:mainfrom Mar 1, 2023
Merged
Conversation
nkhristinin
added
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
yctercero
reviewed
Feb 27, 2023
| */ | ||
| describe('Threat match type rules', () => { | ||
| before(async () => { | ||
| // await deleteSignalsIndex(supertest, log); |
Contributor
There was a problem hiding this comment.
Nit: can we delete these?
yctercero
approved these changes
Feb 27, 2023
Contributor
yctercero
left a comment
yctercero
left a comment
There was a problem hiding this comment.
LGTM!
I may have missed it, but is there a test that includes an exceptions list?
Contributor
Author
Yes, you right, I created issue for that |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
Added several tests for terms query rules, which tests that match and term query rules are the same. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
For posterity: these tests cover the changes introduced in #144511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added several tests for terms query rules, which tests that match and term query rules are the same.