Conversation
…d getFieldsAndIndicesForWildcard
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
@mattkime seems the rabbit hole wasn't so deep as I expected! 👍 |
| // If allowNoIndex, only update field list if field caps finds fields. To support | ||
| // beats creating index pattern and dashboard before docs | ||
| if (!options.allowNoIndex || (newFields && newFields.length > 5)) { | ||
| if (!options.allowNoIndex || (newFields && newFields.length > 4)) { |
There was a problem hiding this comment.
I suspect this fixes a test ... but curious... why?
There was a problem hiding this comment.
I'm going to close this PR is favor of #152059 although I'm going to move some test fixes over.
the allowNoIndices data views attribute changes some field list loading behavior. It was a hack added to prevent the display of errors for the ingest team before data was present. It was always a terrible hack, I think it was added after feature freeze, one of those 'we need to do this so we can ship software, we'll think this through later'.
The code that uses the dataViews.allowNoIndices attribute should be examined for removal.
The PR I opened only changes the allowNoIndices param for field list loading.
| body: { | ||
| version: '2.0.0', | ||
| }, | ||
| refresh: 'wait_for', |
There was a problem hiding this comment.
This fixes a test, but I'm also curious: why, or ... why did it work before. given we tell elasticsearch not to refresh the index instantly?
| expect(await PageObjects.discover.getSidebarAriaDescription()).to.be( | ||
| '0 available fields. 0 meta fields.' | ||
| '0 available fields. 0 empty fields. 0 meta fields.' | ||
| ); | ||
| // ask team how this should be handled | ||
| /* | ||
| await testSubjects.existOrFail( | ||
| `${PageObjects.discover.getSidebarSectionSelector('available')}-fetchWarning` | ||
| ); | ||
| */ |
There was a problem hiding this comment.
that's a good question, given we no longer treat missing indices as error, there's also no reason to show a warning here IMO
3 participants
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers