[Synthetics] adjust permissions for private locations#152037
Merged
dominiqueclarke merged 13 commits intoelastic:mainfrom Mar 1, 2023
Merged
[Synthetics] adjust permissions for private locations#152037dominiqueclarke merged 13 commits intoelastic:mainfrom
dominiqueclarke merged 13 commits intoelastic:mainfrom
Conversation
…private-location-permissions
dominiqueclarke
force-pushed
the
fix/synthetics-private-location-permissions
branch
from
2275437 to
4abef55
Compare
…/github.com/dominiqueclarke/kibana into fix/synthetics-private-location-permissions
dominiqueclarke
force-pushed
the
fix/synthetics-private-location-permissions
branch
from
4abef55 to
3947dfe
Compare
dominiqueclarke
changed the title
dominiqueclarke
added
bug
Contributor
Author
|
@florent-leborgne I'm not sure when to use the word permissions and when to use the word privileges. |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
florent-leborgne
approved these changes
Feb 27, 2023
Contributor
florent-leborgne
left a comment
florent-leborgne
left a comment
There was a problem hiding this comment.
LGTM with some small suggestions. "Privilege" seems to be the correct term to use for Kibana.
x-pack/plugins/synthetics/public/apps/synthetics/components/common/components/permissions.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/synthetics/public/apps/synthetics/components/common/components/permissions.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
@florent-leborgne You'll notice in the heading for the callout, we use the word 'Permissions' instead of 'Privileges'. Is this correct? |
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Contributor
|
@dominiqueclarke Oh I'm sorry, I missed that text in the PR review. We should use privileges as well. We could replace "Need permissions" with "You're missing some Kibana privileges to use private locations" or something along those lines ('use' could be 'manage'). For reference: Kibana privileges docs |
shahzad31
approved these changes
Feb 28, 2023
Contributor
shahzad31
left a comment
shahzad31
left a comment
There was a problem hiding this comment.
LGTM !!
Thank you for clarifying these permissions !!
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2023
## Summary Resolves elastic#150725 Adds `Integrations: All` permissions requirement for interacting with Private locations A user without permissions <img width="1500" alt="Screen Shot 2023-02-23 at 3 26 15 PM" src="https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png"> <img width="354" alt="Screen Shot 2023-02-23 at 3 26 06 PM" src="https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png"> <img width="359" alt="Screen Shot 2023-02-23 at 3 26 01 PM" src="https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png"> <img width="1510" alt="Screen Shot 2023-02-23 at 2 36 02 PM" src="https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png"> <img width="1521" alt="Screen Shot 2023-02-23 at 1 16 38 PM" src="https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png"> <img width="1509" alt="Screen Shot 2023-02-23 at 12 28 08 PM" src="https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png"> A user with permissions <img width="1520" alt="Screen Shot 2023-02-23 at 1 22 11 PM" src="https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png"> ### Testing 1. Create a user with the following permissions ``` Index: synthetics-*: read Kibana: Uptime/Synthetics: All. Integrations: All ``` 2. Log in as that user 3. Navigate to Private locations in Synthetics settings. Confirm the add agent button is disabled and the need permission notice appears 4. Log in as a super user, create a private location 5. Log out, log in as the regular Uptime user 6. Navigate to Private locations in Synthetics settings. Confirm the create location button is disabled and the need permission notice appears --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> (cherry picked from commit d86f2f8)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2023
…#152409) # Backport This will backport the following commits from `main` to `8.7`: - [[Synthetics] adjust permissions for private locations (#152037)](#152037) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-03-01T00:40:49Z","message":"[Synthetics] adjust permissions for private locations (#152037)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/150725\r\n\r\nAdds `Integrations: All` permissions requirement for interacting with\r\nPrivate locations\r\n\r\nA user without permissions\r\n<img width=\"1500\" alt=\"Screen Shot 2023-02-23 at 3 26 15 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png\">\r\n<img width=\"354\" alt=\"Screen Shot 2023-02-23 at 3 26 06 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png\">\r\n<img width=\"359\" alt=\"Screen Shot 2023-02-23 at 3 26 01 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png\">\r\n<img width=\"1510\" alt=\"Screen Shot 2023-02-23 at 2 36 02 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png\">\r\n<img width=\"1521\" alt=\"Screen Shot 2023-02-23 at 1 16 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png\">\r\n<img width=\"1509\" alt=\"Screen Shot 2023-02-23 at 12 28 08 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png\">\r\n\r\nA user with permissions\r\n<img width=\"1520\" alt=\"Screen Shot 2023-02-23 at 1 22 11 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png\">\r\n\r\n### Testing\r\n\r\n1. Create a user with the following permissions\r\n```\r\nIndex: synthetics-*: read\r\nKibana: Uptime/Synthetics: All. Integrations: All\r\n```\r\n2. Log in as that user\r\n3. Navigate to Private locations in Synthetics settings. Confirm the add\r\nagent button is disabled and the need permission notice appears\r\n4. Log in as a super user, create a private location\r\n5. Log out, log in as the regular Uptime user\r\n6. Navigate to Private locations in Synthetics settings. Confirm the\r\ncreate location button is disabled and the need permission notice\r\nappears\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <florent.leborgne@elastic.co>","sha":"d86f2f8eb95f03b5fff44410a3371b169ec27e31","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":152037,"url":"https://github.com/elastic/kibana/pull/152037","mergeCommit":{"message":"[Synthetics] adjust permissions for private locations (#152037)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/150725\r\n\r\nAdds `Integrations: All` permissions requirement for interacting with\r\nPrivate locations\r\n\r\nA user without permissions\r\n<img width=\"1500\" alt=\"Screen Shot 2023-02-23 at 3 26 15 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png\">\r\n<img width=\"354\" alt=\"Screen Shot 2023-02-23 at 3 26 06 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png\">\r\n<img width=\"359\" alt=\"Screen Shot 2023-02-23 at 3 26 01 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png\">\r\n<img width=\"1510\" alt=\"Screen Shot 2023-02-23 at 2 36 02 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png\">\r\n<img width=\"1521\" alt=\"Screen Shot 2023-02-23 at 1 16 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png\">\r\n<img width=\"1509\" alt=\"Screen Shot 2023-02-23 at 12 28 08 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png\">\r\n\r\nA user with permissions\r\n<img width=\"1520\" alt=\"Screen Shot 2023-02-23 at 1 22 11 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png\">\r\n\r\n### Testing\r\n\r\n1. Create a user with the following permissions\r\n```\r\nIndex: synthetics-*: read\r\nKibana: Uptime/Synthetics: All. Integrations: All\r\n```\r\n2. Log in as that user\r\n3. Navigate to Private locations in Synthetics settings. Confirm the add\r\nagent button is disabled and the need permission notice appears\r\n4. Log in as a super user, create a private location\r\n5. Log out, log in as the regular Uptime user\r\n6. Navigate to Private locations in Synthetics settings. Confirm the\r\ncreate location button is disabled and the need permission notice\r\nappears\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <florent.leborgne@elastic.co>","sha":"d86f2f8eb95f03b5fff44410a3371b169ec27e31"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152037","number":152037,"mergeCommit":{"message":"[Synthetics] adjust permissions for private locations (#152037)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/150725\r\n\r\nAdds `Integrations: All` permissions requirement for interacting with\r\nPrivate locations\r\n\r\nA user without permissions\r\n<img width=\"1500\" alt=\"Screen Shot 2023-02-23 at 3 26 15 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png\">\r\n<img width=\"354\" alt=\"Screen Shot 2023-02-23 at 3 26 06 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png\">\r\n<img width=\"359\" alt=\"Screen Shot 2023-02-23 at 3 26 01 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png\">\r\n<img width=\"1510\" alt=\"Screen Shot 2023-02-23 at 2 36 02 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png\">\r\n<img width=\"1521\" alt=\"Screen Shot 2023-02-23 at 1 16 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png\">\r\n<img width=\"1509\" alt=\"Screen Shot 2023-02-23 at 12 28 08 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png\">\r\n\r\nA user with permissions\r\n<img width=\"1520\" alt=\"Screen Shot 2023-02-23 at 1 22 11 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png\">\r\n\r\n### Testing\r\n\r\n1. Create a user with the following permissions\r\n```\r\nIndex: synthetics-*: read\r\nKibana: Uptime/Synthetics: All. Integrations: All\r\n```\r\n2. Log in as that user\r\n3. Navigate to Private locations in Synthetics settings. Confirm the add\r\nagent button is disabled and the need permission notice appears\r\n4. Log in as a super user, create a private location\r\n5. Log out, log in as the regular Uptime user\r\n6. Navigate to Private locations in Synthetics settings. Confirm the\r\ncreate location button is disabled and the need permission notice\r\nappears\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <florent.leborgne@elastic.co>","sha":"d86f2f8eb95f03b5fff44410a3371b169ec27e31"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
![https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png\">\r\n<img](https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png\">\r\n<img){kind=link}
![https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png\">\r\n\r\nA](https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png\">\r\n\r\nA){kind=link}
![https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png\">\r\n\r\n###](https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png\">\r\n\r\n###){kind=link}
## Summary Resolves elastic#150725 Adds `Integrations: All` permissions requirement for interacting with Private locations A user without permissions <img width="1500" alt="Screen Shot 2023-02-23 at 3 26 15 PM" src="https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png"> <img width="354" alt="Screen Shot 2023-02-23 at 3 26 06 PM" src="https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png"> <img width="359" alt="Screen Shot 2023-02-23 at 3 26 01 PM" src="https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png"> <img width="1510" alt="Screen Shot 2023-02-23 at 2 36 02 PM" src="https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png"> <img width="1521" alt="Screen Shot 2023-02-23 at 1 16 38 PM" src="https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png"> <img width="1509" alt="Screen Shot 2023-02-23 at 12 28 08 PM" src="https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png"> A user with permissions <img width="1520" alt="Screen Shot 2023-02-23 at 1 22 11 PM" src="https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png"> ### Testing 1. Create a user with the following permissions ``` Index: synthetics-*: read Kibana: Uptime/Synthetics: All. Integrations: All ``` 2. Log in as that user 3. Navigate to Private locations in Synthetics settings. Confirm the add agent button is disabled and the need permission notice appears 4. Log in as a super user, create a private location 5. Log out, log in as the regular Uptime user 6. Navigate to Private locations in Synthetics settings. Confirm the create location button is disabled and the need permission notice appears --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #150725
Adds
Integrations: Allpermissions requirement for interacting with Private locationsA user without permissions
A user with permissions
Testing