Skip to content

[Synthetics] Private location , remove deprecated api usage#151996

Merged
shahzad31 merged 8 commits intoelastic:mainfrom
shahzad31:remove-so-api
Mar 1, 2023
Merged

[Synthetics] Private location , remove deprecated api usage#151996
shahzad31 merged 8 commits intoelastic:mainfrom
shahzad31:remove-so-api

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Feb 23, 2023

Summary

Private location , remove deprecated api usage

fixes #147773
fixes #151762
fixes #152364

@shahzad31 shahzad31 added v8.7.0 v8.8.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 23, 2023
@shahzad31 shahzad31 marked this pull request as ready for review February 23, 2023 14:27
@shahzad31 shahzad31 requested a review from a team as a code owner February 23, 2023 14:27
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.4MB 1.4MB +781.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

References to deprecated APIs

id before after diff
synthetics 115 109 -6

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 60b34d1 into elastic:main Mar 1, 2023
@shahzad31 shahzad31 deleted the remove-so-api branch March 1, 2023 06:36
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2023
…151996)

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
(cherry picked from commit 60b34d1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 1, 2023
…51996) (#152417)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Synthetics] Private location , remove deprecated api usage
(#151996)](#151996)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-03-01T06:36:38Z","message":"[Synthetics]
Private location , remove deprecated api usage
(#151996)\n\nCo-authored-by: Dominique Clarke
<dominique.clarke@elastic.co>","sha":"60b34d14619fbbeeef477b3b7a9894a0562772dd","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":151996,"url":"https://github.com/elastic/kibana/pull/151996","mergeCommit":{"message":"[Synthetics]
Private location , remove deprecated api usage
(#151996)\n\nCo-authored-by: Dominique Clarke
<dominique.clarke@elastic.co>","sha":"60b34d14619fbbeeef477b3b7a9894a0562772dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151996","number":151996,"mergeCommit":{"message":"[Synthetics]
Private location , remove deprecated api usage
(#151996)\n\nCo-authored-by: Dominique Clarke
<dominique.clarke@elastic.co>","sha":"60b34d14619fbbeeef477b3b7a9894a0562772dd"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
…151996)

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0 v8.8.0

Projects

None yet

5 participants