[Enterprise Search] Consistent spacing fixes#151866
Merged
efegurkan merged 8 commits intoelastic:mainfrom Feb 28, 2023
Merged
Conversation
efegurkan
changed the title
efegurkan
added
release_note:skip
sphilipse
reviewed
Feb 28, 2023
Member
sphilipse
left a comment
sphilipse
left a comment
There was a problem hiding this comment.
Awesome! Only one question.
| export interface PageIntroductionProps { | ||
| actions?: React.ReactNode | React.ReactNode[]; | ||
| description: React.ReactNode | string; | ||
| links?: { href: string; text: string } | Array<{ href: string; text: string }>; |
Member
There was a problem hiding this comment.
question: Did you consider making this a React.ReactNode input as well, so we make the consumers responsible for providing the link? I'm not sure that's better but it may prove more flexible.
Member
Author
There was a problem hiding this comment.
That could be a good idea, I will do the changes
sphilipse
approved these changes
Feb 28, 2023
Member
|
I'm adding v8.7.0 so we backport this, too :) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
## Summary Introduces a new page introduction component to be used in various places. This way we ensure spacing are correct and consistent in between configuration tabs. https://user-images.githubusercontent.com/1410658/221848745-989687b4-1826-48b2-b9c8-fe5750d57c6e.mov ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new page introduction component to be used in various places. This way we ensure spacing are correct and consistent in between configuration tabs.
Screen.Recording.2023-02-27.at.17.40.47.mov
Checklist
Delete any items that are not applicable to this PR.