[Security Solution] adding cypress test for histogram actions#151086
Merged
christineweng merged 5 commits intoelastic:mainfrom Feb 21, 2023
Merged
[Security Solution] adding cypress test for histogram actions#151086christineweng merged 5 commits intoelastic:mainfrom
christineweng merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
PhilippeOberti
requested changes
Feb 14, 2023
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
I'm not super familiar with how this team write Cypress tests yet, so feel free to ignore some of my comments :)
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Feb 16, 2023
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/alerts_charts.cy.ts
Show resolved
Hide resolved
Contributor
MadameSheema
left a comment
There was a problem hiding this comment.
@christineweng this is a great start!! some changes may help to have more readable and stable tests.
The recommendations added can be used/follow on the rest of the code.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cypress tests to replace:
Alert page
Note that in https://docs.google.com/spreadsheets/d/1-240E5E5QhKyTd0C0b4rSQgto1KBmImt/edit#gid=1306255595,
show top nis mentioned as part of the hover actions, however, top n is not present in histogram legends in previous releasev8.6 on siem.dev