Skip to content

[Security Solution] adding cypress test for histogram actions#151086

Merged
christineweng merged 5 commits intoelastic:mainfrom
christineweng:cy-trend-hover-actions
Feb 21, 2023
Merged

[Security Solution] adding cypress test for histogram actions#151086
christineweng merged 5 commits intoelastic:mainfrom
christineweng:cy-trend-hover-actions

Conversation

@christineweng
Copy link
Contributor

@christineweng christineweng commented Feb 13, 2023

Summary

Cypress tests to replace:

Alert page

  • C77187 | Verify that user is able to filter out, add filter the alerts from Detection trend

Note that in https://docs.google.com/spreadsheets/d/1-240E5E5QhKyTd0C0b4rSQgto1KBmImt/edit#gid=1306255595, show top n is mentioned as part of the hover actions, however, top n is not present in histogram legends in previous release

v8.6 on siem.dev

image

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.7.0 v8.8.0 labels Feb 13, 2023
@christineweng christineweng self-assigned this Feb 13, 2023
@christineweng christineweng changed the title [Security Solution] cypress test for testing histogram actions [Security Solution] adding cypress test for histogram actions Feb 13, 2023
@christineweng christineweng marked this pull request as ready for review February 13, 2023 22:44
@christineweng christineweng requested review from a team as code owners February 13, 2023 22:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with how this team write Cypress tests yet, so feel free to ignore some of my comments :)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!
Only thing I would have personally done different are the title of the tests (see the notes under #2 here), but until we decide the format/pattern as a team, I would keep what you have.

Copy link
Contributor

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christineweng this is a great start!! some changes may help to have more readable and stable tests.

The recommendations added can be used/follow on the rest of the code.

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

@christineweng christineweng merged commit 64a5b97 into elastic:main Feb 21, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.7 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 151086

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants