Skip to content

[Security Solution][Alerts] addresses IM performance PR feedback#150677

Merged
vitaliidm merged 8 commits intoelastic:mainfrom
vitaliidm:alerts/im-feedback
Mar 1, 2023
Merged

[Security Solution][Alerts] addresses IM performance PR feedback#150677
vitaliidm merged 8 commits intoelastic:mainfrom
vitaliidm:alerts/im-feedback

Conversation

@vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Feb 9, 2023 •
edited by kibanamachine
Loading

Summary

More details in comments of the initial PR

@vitaliidm vitaliidm self-assigned this Feb 9, 2023
@vitaliidm vitaliidm mentioned this pull request Feb 9, 2023
Merged
2 tasks
@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team backport:prev-minor v8.8.0 v8.7.0 labels Feb 9, 2023
kibanamachine and others added 3 commits February 9, 2023 13:02
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
e1f291b 
…-fix'
@vitaliidm
fix eslint
834c9f8
@vitaliidm
Merge branch 'alerts/im-feedback' of https://github.com/vitaliidm/kibana
fda967c 
 into alerts/im-feedback

# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/threat_mapping/get_signals_map_from_threat_index.ts
@vitaliidm vitaliidm added the Feature:Detection Alerts Security Solution Detection Alerts Feature label Feb 9, 2023
@vitaliidm vitaliidm marked this pull request as ready for review February 9, 2023 15:08
@vitaliidm vitaliidm requested a review from a team as a code owner February 9, 2023 15:09
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 9, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm requested review from a team and marshallmain February 9, 2023 15:09
@kibana-ci
Copy link

kibana-ci commented Feb 27, 2023

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

marshallmain
marshallmain approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@marshallmain marshallmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitaliidm vitaliidm merged commit c08cdc8 into elastic:main Mar 1, 2023
@kibanamachine kibanamachine mentioned this pull request Mar 1, 2023
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2023
@vitaliidm @kibanamachine
[Security Solution][Alerts] addresses IM performance PR feedback (ela…
e00d4ae 
…stic#150677)

## Summary

- addresses feedback from elastic#149208
- typings for `getSignalsQueryMapFromThreatIndex`
- fixes interface name for `getSignalsQueryMapFromThreatIndex`
- small code refactorings

More details in comments of the initial PR

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c08cdc8)
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 1, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 1, 2023
@kibanamachine @vitaliidm
[8.7] [Security Solution][Alerts] addresses IM performance PR feedback (
c17044e 
#150677) (#152426)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Alerts] addresses IM performance PR feedback
(#150677)](#150677)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-03-01T09:46:23Z","message":"[Security
Solution][Alerts] addresses IM performance PR feedback (#150677)\n\n##
Summary\r\n\r\n- addresses feedback from
https://github.com/elastic/kibana/pull/149208\r\n- typings for
`getSignalsQueryMapFromThreatIndex`\r\n- fixes interface name for
`getSignalsQueryMapFromThreatIndex`\r\n- small code
refactorings\r\n\r\nMore details in comments of the initial
PR\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c08cdc8db633a02ac65d0940a26e5f5a86542d9b","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","Feature:Detection Alerts","Team:Detection
Alerts","backport:prev-minor","v8.7.0","v8.8.0"],"number":150677,"url":"https://github.com/elastic/kibana/pull/150677","mergeCommit":{"message":"[Security
Solution][Alerts] addresses IM performance PR feedback (#150677)\n\n##
Summary\r\n\r\n- addresses feedback from
https://github.com/elastic/kibana/pull/149208\r\n- typings for
`getSignalsQueryMapFromThreatIndex`\r\n- fixes interface name for
`getSignalsQueryMapFromThreatIndex`\r\n- small code
refactorings\r\n\r\nMore details in comments of the initial
PR\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c08cdc8db633a02ac65d0940a26e5f5a86542d9b"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150677","number":150677,"mergeCommit":{"message":"[Security
Solution][Alerts] addresses IM performance PR feedback (#150677)\n\n##
Summary\r\n\r\n- addresses feedback from
https://github.com/elastic/kibana/pull/149208\r\n- typings for
`getSignalsQueryMapFromThreatIndex`\r\n- fixes interface name for
`getSignalsQueryMapFromThreatIndex`\r\n- small code
refactorings\r\n\r\nMore details in comments of the initial
PR\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c08cdc8db633a02ac65d0940a26e5f5a86542d9b"}}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@vitaliidm @kibanamachine @bmorelli25
[Security Solution][Alerts] addresses IM performance PR feedback (ela…
d722f74 
…stic#150677)

## Summary

- addresses feedback from elastic#149208
- typings for `getSignalsQueryMapFromThreatIndex`
- fixes interface name for `getSignalsQueryMapFromThreatIndex`
- small code refactorings

More details in comments of the initial PR

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@vitaliidm vitaliidm deleted the alerts/im-feedback branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marshallmain marshallmain marshallmain approved these changes

Assignees

@vitaliidm vitaliidm

Labels

Feature:Detection Alerts Security Solution Detection Alerts Feature release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0 v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vitaliidm @elasticmachine @kibana-ci @kibanamachine @marshallmain