Skip to content

[Lens] Reinstate config errors in embeddable#150650

Merged
drewdaemon merged 8 commits intoelastic:mainfrom
drewdaemon:reinstate-config-errors-on-dashboard
Feb 13, 2023
Merged

[Lens] Reinstate config errors in embeddable#150650
drewdaemon merged 8 commits intoelastic:mainfrom
drewdaemon:reinstate-config-errors-on-dashboard

Conversation

@drewdaemon
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon commented Feb 8, 2023 •
edited by kibanamachine
Loading

Summary

The following fundamental configuration errors were lost in #147818

  • the visualization type is missing
  • the visualization type is unrecognized
  • the datasource type is unrecognized

This adds them back and validates with a functional test to prevent future regressions.

@drewdaemon drewdaemon added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Lens backport:prev-minor labels Feb 8, 2023
@drewdaemon drewdaemon changed the title Reinstate config errors on dashboard [Lens] Reinstate config errors in embeddable Feb 8, 2023
@drewdaemon
Copy link
Copy Markdown
Contributor Author

drewdaemon commented Feb 9, 2023

@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review February 10, 2023 01:05
@drewdaemon drewdaemon requested a review from a team as a code owner February 10, 2023 01:05
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 10, 2023

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon drewdaemon added the release_note:skip Skip the PR/issue when compiling release notes label Feb 10, 2023
stratoula
stratoula approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 13, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #54 / spaces api without security _update_objects_spaces multi-part tests in the default space "before all" hook for "should return 200 {objects: [alias_delete_inclusive], spacesToAdd: [], spacesToRemove: [space_2]}"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 6e3551d into elastic:main Feb 13, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 13, 2023
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 13, 2023
@drewdaemon
[Lens] Reinstate config errors in embeddable (elastic#150650)
02cdd29 
(cherry picked from commit 6e3551d)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 13, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Mar 2, 2023
Merged
9 tasks
@dej611 dej611 mentioned this pull request Mar 7, 2023
Merged
@dej611
Copy link
Copy Markdown
Contributor

dej611 commented Mar 7, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dej611 pushed a commit to dej611/kibana that referenced this pull request Mar 7, 2023
@drewdaemon
[Lens] Reinstate config errors in embeddable (elastic#150650)
25bbceb 
(cherry picked from commit 6e3551d)
dej611 added a commit that referenced this pull request Mar 7, 2023
@dej611 @drewdaemon
[8.7] [Lens] Reinstate config errors in embeddable (#150650) (#152798)
0e2c874 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Lens] Reinstate config errors in embeddable
(#150650)](#150650)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2023-02-13T17:07:23Z","message":"[Lens]
Reinstate config errors in embeddable
(#150650)","sha":"6e3551d9dad5fc15be91b37b2632064a69d491b4","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.8.0"],"number":150650,"url":"https://github.com/elastic/kibana/pull/150650","mergeCommit":{"message":"[Lens]
Reinstate config errors in embeddable
(#150650)","sha":"6e3551d9dad5fc15be91b37b2632064a69d491b4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150650","number":150650,"mergeCommit":{"message":"[Lens]
Reinstate config errors in embeddable
(#150650)","sha":"6e3551d9dad5fc15be91b37b2632064a69d491b4"}},{"url":"https://github.com/elastic/kibana/pull/151049","number":151049,"branch":"8.7","state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: Drew Tate <drew.tate@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.7.0 v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@drewdaemon @elasticmachine @kibana-ci @kibanamachine @dej611 @stratoula