Skip to content

[Flaky Test] Unskips 'single-namespace types' copy to space tests#150492

Merged
jeramysoucy merged 5 commits intoelastic:mainfrom
jeramysoucy:unskips-copy-to-space
Feb 9, 2023
Merged

[Flaky Test] Unskips 'single-namespace types' copy to space tests#150492
jeramysoucy merged 5 commits intoelastic:mainfrom
jeramysoucy:unskips-copy-to-space

Conversation

@jeramysoucy
Copy link
Contributor

@jeramysoucy jeramysoucy commented Feb 7, 2023 •
edited by kibanamachine
Loading

@jeramysoucy jeramysoucy added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes test-failure-flaky v8.7.0 labels Feb 7, 2023
@jeramysoucy jeramysoucy marked this pull request as ready for review February 8, 2023 19:02
@jeramysoucy jeramysoucy requested a review from a team as a code owner February 8, 2023 19:02
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 8, 2023

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link

kibana-ci commented Feb 8, 2023

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jeramysoucy jeramysoucy merged commit c0c023a into elastic:main Feb 9, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 9, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2023
@jeramysoucy
[Flaky Test] Unskips 'single-namespace types' copy to space tests (el…
6f00bf3 
…astic#150492)

closes elastic#86545
closes elastic#149544
closes elastic#149547
closes elastic#149563

Fixed by PR elastic#149582

- [Flaky test runner on
x-pack/test/spaces_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1880)
- [Flaky test runner on
x-pack/test/saved_object_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1888)

(cherry picked from commit c0c023a)
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 9, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 9, 2023
@kibanamachine @jeramysoucy
[8.7] [Flaky Test] Unskips 'single-namespace types' copy to space tes…
5cc66cb 
…ts (#150492) (#150724)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Flaky Test] Unskips 'single-namespace types' copy to space tests
(#150492)](#150492)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T15:00:02Z","message":"[Flaky
Test] Unskips 'single-namespace types' copy to space tests
(#150492)\n\ncloses #86545\r\ncloses #149544\r\ncloses #149547\r\ncloses
#149563 \r\n\r\nFixed by PR #149582\r\n\r\n- [Flaky test runner
on\r\nx-pack/test/spaces_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1880)\r\n-
[Flaky test runner
on\r\nx-pack/test/saved_object_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1888)","sha":"c0c023aaa6bf977a8a7a357998d612f04ea2f024","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","test-failure-flaky","v8.7.0","v8.8.0"],"number":150492,"url":"https://github.com/elastic/kibana/pull/150492","mergeCommit":{"message":"[Flaky
Test] Unskips 'single-namespace types' copy to space tests
(#150492)\n\ncloses #86545\r\ncloses #149544\r\ncloses #149547\r\ncloses
#149563 \r\n\r\nFixed by PR #149582\r\n\r\n- [Flaky test runner
on\r\nx-pack/test/spaces_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1880)\r\n-
[Flaky test runner
on\r\nx-pack/test/saved_object_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1888)","sha":"c0c023aaa6bf977a8a7a357998d612f04ea2f024"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150492","number":150492,"mergeCommit":{"message":"[Flaky
Test] Unskips 'single-namespace types' copy to space tests
(#150492)\n\ncloses #86545\r\ncloses #149544\r\ncloses #149547\r\ncloses
#149563 \r\n\r\nFixed by PR #149582\r\n\r\n- [Flaky test runner
on\r\nx-pack/test/spaces_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1880)\r\n-
[Flaky test runner
on\r\nx-pack/test/saved_object_api_integration/security_and_spaces](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1888)","sha":"c0c023aaa6bf977a8a7a357998d612f04ea2f024"}}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@watson watson watson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// test-failure-flaky v8.7.0 v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/copy_to_space·ts - spaces api with security copy to spaces user with no access from the default space multi-namespace types with overwrite=false and createNewCopies=false "after all" hook for "should return 403 when copying with an ambiguous conflict" Failing test: X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/bulk_create·ts - saved objects security and spaces enabled _bulk_create user with read at the space within the default space should return 403 forbidden [sharedtype/new-all-spaces-id] Failing test: X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/bulk_create·ts - saved objects security and spaces enabled _bulk_create legacy user within the default space "before all" hook for "should return 403 forbidden [isolatedtype/defaultspace-isolatedtype-id]" Failing test: X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/copy_to_space·ts - spaces api with security copy to spaces user with no access from the default space single-namespace types "after each" hook for "should return 403 when copying to space without conflicts or references"

5 participants

@jeramysoucy @elasticmachine @kibana-ci @kibanamachine @watson