[Lens] don't block render on missing sort field#150356
Merged
drewdaemon merged 1 commit intoelastic:mainfrom Feb 6, 2023
Merged
[Lens] don't block render on missing sort field#150356drewdaemon merged 1 commit intoelastic:mainfrom
drewdaemon merged 1 commit intoelastic:mainfrom
Conversation
drewdaemon
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
drewdaemon
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
part of #143673
In the case where only the sort field is missing, you'll get an Elasticsearch error displayed in place of the visualization. So we thought we should have the missing field error shown in the workspace instead since that's the real problem.
However, doing this can cause the integration dashboards to suffer from the same issue that #149262 was trying to resolve since many of them have last-value operations with sort fields.
The lesser of the evils is just to not block the render no matter what. In the scenario where only the sort field is missing from a configuration, they will see the elasticsearch error in the workspace, but will still see the missing field error in the messages list and the error dimension. This scenario also seems like an edge case, while the integration dashboards are installed every day.