Skip to content

[Security Solution] Avoid exporting execution_summary field #150097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maximpn merged 1 commit into from
Feb 2, 2023
Merged

[Security Solution] Avoid exporting execution_summary field #150097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...tion/server/lib/detection_engine/rule_management/logic/export/get_export_by_object_ids.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,14 @@ export const getRulesFromObjects = async (
isAlertType(matchingRule) &&
matchingRule.params.immutable !== true
) {
const rule = internalRuleToAPIResponse(matchingRule, legacyActions[matchingRule.id]);

// Fields containing runtime information shouldn't be exported. It causes import failures.
delete rule.execution_summary;
Comment on lines +121 to +124
Copy link
Copy Markdown
Contributor

@banderror banderror Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Let's extract this into a function with a clear name, e.g. transformRuleToExportableFormat or something like that


return {
statusCode: 200,
rule: internalRuleToAPIResponse(matchingRule, legacyActions[matchingRule.id]),
rule,
};
} else {
return {
Expand Down