Skip to content

Add link to ingest pipeline dashboard from Stack Monitoring#149721

Merged
joshdover merged 6 commits intoelastic:mainfrom
joshdover:ip-monitoring-link
Feb 3, 2023
Merged

Add link to ingest pipeline dashboard from Stack Monitoring#149721
joshdover merged 6 commits intoelastic:mainfrom
joshdover:ip-monitoring-link

Conversation

@joshdover
Copy link
Copy Markdown
Contributor

@joshdover joshdover commented Jan 27, 2023 •
edited
Loading

Summary

Closes #149386

This adds a new link in Stack Monitoring to the Ingest Pipeline dashboard that will be shipping in the Elasticsearch integration package. Rather than building a custom UI for displaying this data, we will ask the user to install the latest integration package to get the dashboard and then link the user there.

The initial dashboard is added in elastic/integrations#4597. Note that testing this will not fully work until the integration PR is merged and the package is available in the registry. In the meantime you can manually download that package and install it via upload (requires trial / enterprise license):

elasticsearch-1.3.0-preview1.zip

curl -XPOST -H 'content-type: application/zip' -H 'kbn-xsrf: true' http://localhost:5601/api/fleet/epm/packages -u elastic:changeme --data-binary @./elasticsearch-1.3.0-preview1.zip

Screenshots

New tab added to Stack Monitoring > Elasticsearch page w/ beta badge + tooltip. When this is clicked and the dashboard is already installed, we navigate directly to the dashboard.

image

image

When the integration is not installed, the user is prompted to install (if they have permission to do so) or told to ask an admin to install it.

image

image

Checklist

Delete any items that are not applicable to this PR.

@joshdover joshdover changed the title [wip] Add link to ingest pipeline dashboard from SM Add link to ingest pipeline dashboard from Stack Monitoring Jan 31, 2023
@joshdover joshdover added enhancement New value added to drive a business result Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:feature Makes this part of the condensed release notes v8.7.0 labels Jan 31, 2023
@joshdover joshdover marked this pull request as ready for review January 31, 2023 10:49
@joshdover joshdover requested a review from a team as a code owner January 31, 2023 10:49
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 31, 2023

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@joshdover joshdover requested a review from klacabane January 31, 2023 10:49
@joshdover joshdover mentioned this pull request Jan 31, 2023
Merged
20 tasks
@miltonhultgren
Copy link
Copy Markdown
Contributor

miltonhultgren commented Feb 1, 2023

When trying:
curl -XPOST -H 'content-type: application/zip' -H 'kbn-xsrf: true' http://localhost:5601/api/fleet/epm/packages -u elastic:changeme --data-binary @./elasticsearch-1.2.0-preview1.zip

I get:
{"statusCode":415,"error":"Unsupported Media Type","message":"Unsupported Media Type"}

Any ideas?

@joshdover
Copy link
Copy Markdown
Contributor Author

joshdover commented Feb 2, 2023

@miltonhultgren if you're using a base path in dev mode you will get this error. You can fix by either using --no-base-path when starting Kibana or add the base path to the curl command.

@joshdover
Copy link
Copy Markdown
Contributor Author

joshdover commented Feb 2, 2023

Also updated the PR description with the latest build of the package which might be necessary now that 1.2.0 is GA.

@miltonhultgren
Copy link
Copy Markdown
Contributor

miltonhultgren commented Feb 2, 2023

@miltonhultgren if you're using a base path in dev mode you will get this error. You can fix by either using --no-base-path when starting Kibana or add the base path to the curl command.

Yeah, that was it. Wish the 404 would hit before the content type error handler!

miltonhultgren
miltonhultgren approved these changes Feb 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Maybe you want design to have a look at the copy text for the dialog, not a blocker though in my opinion.

@formgeist Could you give some quick feedback on that perhaps?

@miltonhultgren miltonhultgren removed the request for review from klacabane February 2, 2023 18:54
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 2, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 447 448 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 452.1KB 455.2KB +3.1KB
Unknown metric groups

References to deprecated APIs

id before after diff
monitoring 2 6 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover
Copy link
Copy Markdown
Contributor Author

joshdover commented Feb 3, 2023

@miltonhultgren thanks for the review. Happy to get some feedback on the copy. I'm going to go ahead an merge this to make feature freeze, but we can easily adjust after FF without risk

@joshdover joshdover merged commit 136171a into elastic:main Feb 3, 2023
@joshdover joshdover deleted the ip-monitoring-link branch February 3, 2023 07:06
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 3, 2023
@neptunian neptunian mentioned this pull request May 26, 2023
Closed
@criamico criamico mentioned this pull request Jun 14, 2023
Merged
criamico added a commit that referenced this pull request Jun 20, 2023
@criamico @kibanamachine
Replace usage of public SO client with Fleet get Bulk Assets api (#15…
58ec0a4 
…9653)

Closes #158598

## Summary

Removes usage of deprecated SO client to fetch dashboard assets;
Replaced with a call to the new Fleet endpoint `epm/bulk_assets`
([openapi](https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/master/x-pack/plugins/fleet/common/openapi/bundled.json#/Elastic%20Package%20Manager%20(EPM)/bulk-get-assets))

## Testing

I'm not very familiar with stack monitoring, so I tried to reproduce
what's described in the
[PR](#149721) that originally
introduced this dashboard; I couldn't trigger the modal but I can see
the endpoint in the network requests:

<img width="3206" alt="Screenshot 2023-06-14 at 09 57 34"
src="https://github.com/elastic/kibana/assets/16084106/b0ff5111-1b1d-42aa-9621-e61c37efedde">

It should be enough to test this change since is very small.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@miltonhultgren miltonhultgren mentioned this pull request Sep 8, 2023
Merged
4 tasks
@consulthys consulthys mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting enhancement New value added to drive a business result release_note:feature Makes this part of the condensed release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Add new tab on ES monitoring page to link to Ingest Pipeline dashboard

5 participants

@joshdover @elasticmachine @miltonhultgren @kibana-ci @kibanamachine