[Lens] Display the metric title on the dashboard panel#149662
Merged
stratoula merged 1 commit intoelastic:mainfrom Jan 27, 2023
Merged
[Lens] Display the metric title on the dashboard panel#149662stratoula merged 1 commit intoelastic:mainfrom
stratoula merged 1 commit intoelastic:mainfrom
Conversation
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
Contributor
|
Thanks for doing this! It will make this way more consistent, and more exciting when all of this information is displayed inside the metric. Can't wait to see how that looks. |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
## Summary Closes elastic#148563 After this [PR]( elastic#148301) being merged, it will be easier to add the description info icon and the custom data range to the new metric. For this reason we decided to also allow the panel title for now. On the next minors we are going to hide it from the panel and display all the aforementioned info on the viz title. <img width="988" alt="image" src="https://user-images.githubusercontent.com/17003240/215037834-0f556673-8628-484e-aa32-c34188fc7064.png"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #148563
After this PR being merged, it will be easier to add the description info icon and the custom data range to the new metric. For this reason we decided to also allow the panel title for now.
On the next minors we are going to hide it from the panel and display all the aforementioned info on the viz title.
Checklist