[Guided onboarding] Change the saved objects' type to hidden

[yuliacech]

Summary

Making the saved objects hidden will prevent other plugins accidentally updating the guided onboarding data directly via the SO client. This was recommended by the Core team and I think it should be safe to change the type since there should not be any existing SO in deployments prior to 8.7 yet.

[elasticmachine]

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

[yuliacech]

I'm putting this PR in draft because we can't currently create/update SO with the test client in functional tests, but a PR for this issue might be a solution for that.

[TinaHeiligers]

can't currently create/update SO with the test client in functional tests

FWIW, right now, you can use es directly in your tests. Take a look at the testing setup other SO type owners use when their types are hidden. For example: cases.

Oh, and now you also have the option of only hiding a type from the HTTP APIs if you won't really benefit from implementing your own SO client.

[yuliacech]

Thanks for the info, @TinaHeiligers! It looks like the new plugin merged in #149188 did the trick though, I run the tests locally and everything passed, will see if the CI does the same.

[yuliacech]

@elastic/kibana-core hey team, could someone please confirm that it's safe to change saved objects used in the guided onboarding plugin to hidden: true? The plugin has not been released yet, so I don't think there should be any issues with migration.

[TinaHeiligers]

Code LGTM. There shouldn't be an issue ith migrations. Changing saved object type to hidden is what we're recommending.
The issue with migrations comes when you want to change an existing saved object attribute, although it's best to confirm with @rudolf

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 288bc3c

Metrics [docs]

✅ unchanged

History

• 💚 Build #104633 succeeded 6f28484
• 💚 Build #103706 succeeded 03058ce
• 💚 Build #102972 succeeded 4932c65
• 💔 Build #101036 failed 1794197
• 💔 Build #100522 failed 4a55f5d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream