move code shared with alerting api-integration plugins into a package #148846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
implement/alerting-api-integration-helpers
branch
from
231b990
to
46681f7
Compare
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
spalger
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
kibanamachine
added
v8.7.0
backport:skip
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
…elastic#148846) We're working on converting all plugins into packages, which turns almost all code in the repository into a package except for things like the `test` and `x-pack/test` directories. The problem we ran into is that the alerting api-integration test plugins are being migrated to packages but they are currently consuming a handful of helpers from the parent `../lib` directory. This doesn't work, as packages can only import other packages and the `../lib` directory isn't in a package, it's just free-floating `x-pack/test` code. To fix this I've moved the necessary components out of `common/lib` and into `packages/helpers` which is importable via `@kbn/alerting-api-integration-helpers` and updated all the uses to access this new package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working on converting all plugins into packages, which turns almost all code in the repository into a package except for things like the
testandx-pack/testdirectories. The problem we ran into is that the alerting api-integration test plugins are being migrated to packages but they are currently consuming a handful of helpers from the parent../libdirectory. This doesn't work, as packages can only import other packages and the../libdirectory isn't in a package, it's just free-floatingx-pack/testcode. To fix this I've moved the necessary components out ofcommon/liband intopackages/helperswhich is importable via@kbn/alerting-api-integration-helpersand updated all the uses to access this new package.