[Saved Objects Management] Encapsulate saved objects deletion behind an API endpoint

[dokmic]

Summary

Resolves #148615.

The API endpoint delegates the delete operation to the bulkDelete (#139680) method of the SO client on the server.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[TinaHeiligers]

Overall, great work!

We need to make sure we don't accidentally call bulk_delete for hidden saved objects. The API won't recognize those and we should give the impression that one can delete hidden objects from SOM.

[TinaHeiligers]

Adding a toast for every failed delete is going to get very noisy for large payloads. It's not a problem for single-item deletes but might cause toast floods for multiple delete failures.

[dokmic]

Alright, I've updated the code to show a single toast only. But I have some concerns that it's better. It seems like we are hiding from the user all the errors we've got during the deletion.
IMO, it's okay to show a toast per each failed operation as we perform it only for the manually selected objects which should not be more than 50 in the worst case.

[TinaHeiligers]

which should not be more than 50 in the worst case

With anything related to saved objects, we cannot assume that. If there aren't any objections from other members of the team, go with what you 'feel' is right.

[TinaHeiligers]

The repository won't recognize hidden saved object types as those aren't recognized as registered unless the hidden types are included. We're not instantiating the client with any hidden types and will need to filter these out in a similar manner as:
https://github.com/elastic/kibana/pull/148602/files#diff-47d724c5a7bb6e8c1286f67e3ed1b117ac27e05387052760388bd477bd76337bL525

    const deletes = selectedSavedObjects
      .filter((object) => !object.meta.hiddenType)
      .map((object) => savedObjectsClient.delete(object.type, object.id, { force: true }));
    await Promise.all(deletes);

[pgayvallet]

Now that we have a dedicated endpoint, we could use a custom client with all hidden types. Not sure if we should, though.

[dokmic]

I implemented that at first but then removed it to keep the existing behavior exactly the same. Just wanted to confirm whether should we ever provide such an option as hidden objects deletion.

[TinaHeiligers]

Just wanted to confirm whether should we ever provide such an option as hidden objects deletion.

Right now, IMHO, no. There are far too many issues that could cause. Type owners specifically register their saved objects as hidden to implement their own APIs and handle dependencies themselves. I don't think we could or even should bypass that and blindly allow users to shoot themselves in the foot. Preventing issues from editing saved objects in SOM is why we changed the edit to view-only in the first place.

Maybe, if we had object-level security we could implement it or even some other "advanced, super scary uber auth" where we have a registry of hidden types' delete APIs to use as the underlying implementation?

[rudolf]

+1 to keep the behaviour as is. In general / long term, I would lean towards removing the delete ability for most types in management and moving that to their listing UIs which I think is also part of content management's vision.

[pgayvallet]

Now that we have a dedicated endpoint, we could use a custom client with all hidden types. Not sure if we should, though.

[dokmic]

@TinaHeiligers @pgayvallet I've updated the PR with some fixes based on your feedback. Would you mind taking another look?

[TinaHeiligers]

I still need to pull the branch and test

[TinaHeiligers]

Code LGTM!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: e8eb772

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
savedObjectsManagement	78	79	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
savedObjectsManagement	83.9KB	84.6KB	+663.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
savedObjectsManagement	19.3KB	19.4KB	+85.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
savedObjectsManagement	157	149	-8

History

• 💔 Build #101224 failed 8e2dd86046991ad5fd73f36aac906aa784a55a98
• 💚 Build #99155 succeeded 7b579b573f7263abc9897d46fba30a7bfd401fdb
• 💔 Build #98996 failed 9ab433233de5d9d0497ec0c48c712e65592e7de0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream