[Security Solution] Prebuilt rule upgrade and installation endpoints, initial implementation #148392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
release_note:skip
banderror
changed the title
12 tasks
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
6 times, most recently
from
3a25d9a
to
8193a41
Compare
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
7 times, most recently
from
bb12c80
to
02a174b
Compare
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
6 times, most recently
from
c4eb9b1
to
04bcdf9
Compare
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
4 times, most recently
from
8242cba
to
1b7ff44
Compare
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
3 times, most recently
from
dad0970
to
eea46c0
Compare
Files by Code Ownerelastic/security-detections-response
elastic/security-detections-response-alerts
elastic/security-detections-response-rules
elastic/security-solution
elastic/security-threat-hunting
|
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
from
3b36a04
to
5f9d3c9
Compare
banderror
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
from
5f9d3c9
to
e68a7fc
Compare
kqualters-elastic
approved these changes
Mar 7, 2023
xcrzx
approved these changes
Mar 7, 2023
|
buildkite test this |
xcrzx
force-pushed
the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
from
e68a7fc
to
5af6476
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @banderror |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
… initial implementation (elastic#148392) **Addresses:** elastic#148181, elastic#148182, elastic#148185 **Partially addresses:** elastic#148183, elastic#148189 ## Summary Based on the [POC](elastic#144060), this PR adds 4 endpoints for the new upgrade and installation workflows for prebuilt rules: - `GET /internal/detection_engine/prebuilt_rules/status` - `POST /internal/detection_engine/prebuilt_rules/upgrade/_review` - `POST /internal/detection_engine/prebuilt_rules/installation/_review` - `POST /internal/detection_engine/prebuilt_rules/_generate_assets` (temporary helper endpoint for development and testing) The new endpoints are hidden behind a feature flag and can be enabled by the following config setting: ```yaml xpack.securitySolution.enableExperimental: ['prebuiltRulesNewUpgradeAndInstallationWorkflowsEnabled'] ``` ## In the next episodes Will be done later in follow-up PRs: - Implementation of some additional response properties for the `upgrade/_review` endpoint: - elastic#148183 - Making base versions optional for diff calculation (we need to support this in order to be able to still show diffs for rule assets coming from packages without historical versions): - elastic#148189 - Further development of the diff algorithm: - elastic#148191 - Test coverage: - elastic#148192
banderror
deleted the
rule-upgrade-and-installation-endpoints-initial-implementation
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #148181, #148182, #148185
Partially addresses: #148183, #148189
Summary
Based on the POC, this PR adds 4 endpoints for the new upgrade and installation workflows for prebuilt rules:
GET /internal/detection_engine/prebuilt_rules/statusPOST /internal/detection_engine/prebuilt_rules/upgrade/_reviewPOST /internal/detection_engine/prebuilt_rules/installation/_reviewPOST /internal/detection_engine/prebuilt_rules/_generate_assets(temporary helper endpoint for development and testing)The new endpoints are hidden behind a feature flag and can be enabled by the following config setting:
In the next episodes
Will be done later in follow-up PRs:
upgrade/_reviewendpoint: