Skip to content

[6.x] Upgrade to webpack 3 (#14315)#14824

Merged
spalger merged 1 commit into
elastic:6.xfrom
spalger:backport/6.x/14315
Nov 7, 2017
Merged

[6.x] Upgrade to webpack 3 (#14315)#14824
spalger merged 1 commit into
elastic:6.xfrom
spalger:backport/6.x/14315

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Nov 7, 2017

  • [timelion] remove last remaining amd modules

  • [eslint-config-kibana] remove env.amd

  • [webpack] use absolute loader names

  • [webpack] remove absolute node_modules/ imports

  • [webpack] upgrade to webpack 3

  • [uiFramework] make webpack build compatible with v3

  • [eslint-import-resolver] use [webpack] upgrade to webpack 3 eslint-import-resolver-kibana#21

  • [baseOptimizer] don't break when pkg has no dependencies

  • [optimize] remove unnecessary json-loader

  • [optimize] remove local references to webpack vars

  • [eslint] upgrade to eslint-import-resolver-kibana 0.9.0

  • [baseOptimizer] comment tweaks

  • [baseOptimizer] remove loader pinning

In webpack 1 the loaders defined here were resolved relative to the file they were going to load, which meant that plugins in other projects could accidentally overwrite the loaders Kibana was trying to use, which is why the aliases were used to enforce proper resolution.

In webpack 2 loaders are now resolved relative to the webpackConfig.context, which is set to the root of the Kibana repo. See https://webpack.js.org/configuration/module/#useentry

  • [webpack] rely on kibana webpack shims before checking node_modules

(cherry picked from commit f60639f)

* [timelion] remove last remaining amd modules

* [eslint-config-kibana] remove env.amd

* [webpack] use absolute loader names

* [webpack] remove absolute node_modules/ imports

* [webpack] upgrade to webpack 3

* [uiFramework] make webpack build compatible with v3

* [eslint-import-resolver] use elastic/eslint-import-resolver-kibana#21

* [baseOptimizer] don't break when pkg has no dependencies

* [optimize] remove unnecessary json-loader

* [optimize] remove local references to webpack vars

* [eslint] upgrade to eslint-import-resolver-kibana 0.9.0

* [baseOptimizer] comment tweaks

* [baseOptimizer] remove loader pinning

In webpack 1 the loaders defined here were resolved relative to the file they were going to load, which meant that plugins in other projects could accidentally overwrite the loaders Kibana was trying to use, which is why the aliases were used to enforce proper resolution.

In webpack 2 loaders are now resolved relative to the webpackConfig.context, which is set to the root of the Kibana repo. See https://webpack.js.org/configuration/module/#useentry

* [webpack] rely on kibana webpack shims before checking node_modules

(cherry picked from commit f60639f)
@spalger spalger added backport This PR is a backport of another PR v6.1.0 labels Nov 7, 2017
@spalger spalger merged commit 4a5ba23 into elastic:6.x Nov 7, 2017
@spalger spalger deleted the backport/6.x/14315 branch November 7, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR v6.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant