[Logs UI] Migrate usages of defineInternalSourceConfiguration to defineInternalLogView with new LogViewService#147673
Merged
tonyghiani merged 6 commits intoelastic:mainfrom Dec 29, 2022
Conversation
…Views.defineInternalLogView
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
….com:tonyghiani/kibana into 129080-switch-to-defineInternalLogView-usage
defineInternalSourceConfiguration to logViews.defineInternalLogViewdefineInternalSourceConfiguration to defineInternalLogView with new LogViewService
Contributor
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
sphilipse
approved these changes
Dec 28, 2022
Member
sphilipse
left a comment
There was a problem hiding this comment.
Enterprise Search changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #129080
With the introduction of the "log view" concept in #125014, this PR migrates all usages of the previous
defineInternalSourceConfigurationfunction in the infra plugin's setup() contract to the newlogViews.defineInternalLogViewfunction on the contract.This affects
enterprise_search,monitoringandupgrade_assistantplugins.N.B. As these usages were not following the same restrictive configuration for the attributes we have now defined in the
.defineInternalLogViewmethod, I made thelogViewAttributespassed tologViews.defineInternalLogViewmerge with thedefaultLogViewAttributes.