[8.6] [Fleet] added a logic to use destinationId when tagging imported SOs (#147439)#147528
Merged
kibanamachine merged 1 commit intoelastic:8.6from Dec 14, 2022
Merged
Conversation
elastic#147439) ## Summary Fixes elastic#147364 When installing an integration, and some assets already exist in Kibana, the imported SOs will recieve a newly generated ID. This caused a problem previously when the tagging logic didn't find the SOs with their original ID. The fix takes the new `destinationId` of those SOs, so the tagging can complete successfully. **Steps to verify** 1. Add system integration in default space 2. Enroll an agent and wait for system metrics to be ingested 3. Create an Admin space 4. Remove the system package policy, and uninstall the system package from Default space 5. Go to Admin space and add system integration again 6. Verify that the integration is added successfully, assets are created in Admin space and assets are tagged with Managed and System tags. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7cee9ff)
botelastic
bot
added
the
Team:Fleet
1 task
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:destinationIdwhen tagging imported SOs (#147439)Questions ?
Please refer to the Backport tool documentation