[8.6] [APM] Switching service groups from grid to flex layout (#147448)#147513
Merged
yngrdyn merged 1 commit intoelastic:8.6from Dec 14, 2022
Merged
[8.6] [APM] Switching service groups from grid to flex layout (#147448)#147513yngrdyn merged 1 commit intoelastic:8.6from
yngrdyn merged 1 commit intoelastic:8.6from
Conversation
Closes elastic#147435. ### Changes - `ServiceGroupList` is now using `EuiFlexGroup`. Grid is not suitable for this case since the `ServiceGroupCard` has a fixed width. - `ServiceGroupCard` width is changed to `100%` when we are in mobile resolutions. **Before** https://user-images.githubusercontent.com/1313018/207371784-60dbb1e3-7295-4d33-a62d-d051d652a2b0.mov **After** https://user-images.githubusercontent.com/1313018/207371298-fc970def-332f-4cfe-9603-efdf68f1ce8e.mov (cherry picked from commit d53a159) # Conflicts: # x-pack/plugins/apm/public/components/app/service_groups/service_groups_list/service_group_card.tsx # x-pack/plugins/apm/public/components/app/service_groups/service_groups_list/service_groups_list.tsx
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation