Fixes the bad alignment issue on the missing dataview text#147433
Merged
stratoula merged 1 commit intoelastic:mainfrom Dec 13, 2022
Merged
Fixes the bad alignment issue on the missing dataview text#147433stratoula merged 1 commit intoelastic:mainfrom
stratoula merged 1 commit intoelastic:mainfrom
Conversation
stratoula
added
Feature:Visualizations
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
stratoula
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
drewdaemon
approved these changes
Dec 13, 2022
dej611
approved these changes
Dec 13, 2022
Contributor
dej611
left a comment
dej611
left a comment
There was a problem hiding this comment.
Tested locally on Safari 👍
nickofthyme
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #147392
Fixes the link alignment issue in both Visualize and Lens.
This has been caused due to an update on the EUI and the fact that the
<RedirectAppLinks/>component adds its own style (flex which makes the link to be aligned on the left), This component is used in many places so I decided to not make css changes there as it might affect other places.