Skip to content

[TIP] fix add integrations link not working in cloud#147362

Merged
PhilippeOberti merged 1 commit intomainfrom
add-integrations-fix
Dec 12, 2022
Merged

[TIP] fix add integrations link not working in cloud#147362
PhilippeOberti merged 1 commit intomainfrom
add-integrations-fix

Conversation

@PhilippeOberti
Copy link
Contributor

Summary

This previous PR updated the Add Integrations logic when the user is clicking from the Threat Intelligence view. We want to navigate to the Integrations screen with the Threat Intelligence category already selected.

Although this was working locally, I had forgotten to modify the code logic when the cloudExperiments plugin is enabled (see here).

https://github.com/elastic/security-team/issues/5008

Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.1MB 10.1MB -2.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 815328c into main Dec 12, 2022
@PhilippeOberti PhilippeOberti deleted the add-integrations-fix branch December 12, 2022 20:39
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants