[Guided Onboarding] Make onboarding panel auto height#147333
[Guided Onboarding] Make onboarding panel auto height#147333cindychangy merged 4 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
| flyoutContainer: css` | ||
| top: 55px !important; | ||
| bottom: 25px !important; | ||
| bottom: unset !important; |
There was a problem hiding this comment.
nit: would it be possible to delete the property completely?
There was a problem hiding this comment.
(If it's not possible to delete, it might be worth adding a comment to explain why.)
There was a problem hiding this comment.
@yuliacech @alisonelizabeth - good point, I added a comment to clarify (does not work if we remove these values) - I had one quick question, is this placement the correct place to put it, or should I add it all the way at the top with the commented description:
/**
*
* Style overrides for the setup guide dropdown panel.
* There is currently no existing EUI component that fully supports what we need...
There was a problem hiding this comment.
I think this is OK 👍. Not sure if there are any specific guidelines around this, but in this case, I think it's easier to follow next to the CSS.
| border-radius: 6px; | ||
| inline-size: 480px !important; | ||
| height: auto; | ||
| height: unset !important; |
There was a problem hiding this comment.
same here, maybe we could delete height?
yuliacech
left a comment
There was a problem hiding this comment.
Thanks a lot, @cindychangy! LGTM, left a couple of nits in the comments.
alisonelizabeth
left a comment
There was a problem hiding this comment.
Verified locally. LGTM. Thanks @cindychangy!
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Fixes issue #144334
Making the panel not take the full height of the screen as is the default of

EuiFlyoutwhich we are using.Notes:
maxWidthprop for theEuiFlyoutso I swapped that with the custom style we hadpanel_styles.tsto achieve thismax-heighton the panel so there is always room for 1 toastLet me know if you think there is a better way to approach this.