Skip to content

[Connectors] Unskip a test for the es index connector#147311

Merged
cnasikas merged 3 commits intoelastic:mainfrom
cnasikas:fix_145751
Dec 13, 2022
Merged

[Connectors] Unskip a test for the es index connector#147311
cnasikas merged 3 commits intoelastic:mainfrom
cnasikas:fix_145751

Conversation

@cnasikas
Copy link
Copy Markdown
Member

@cnasikas cnasikas commented Dec 9, 2022

Summary

This PR unskips a test that was skipped during the Jest upgrade to version 29.

Fixes #145751

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Dec 9, 2022
@cnasikas cnasikas self-assigned this Dec 9, 2022
@cnasikas cnasikas requested review from a team as code owners December 9, 2022 14:02
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Dec 9, 2022
@cnasikas
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnasikas
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas enabled auto-merge (squash) December 13, 2022 21:04
@cnasikas cnasikas merged commit 26e6641 into elastic:main Dec 13, 2022
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / APM API tests basic no data Service group counts with alerts "before all" hook for "returns the correct number of alerts"

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas deleted the fix_145751 branch December 13, 2022 22:07
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Dec 13, 2022
nreese pushed a commit to nreese/kibana that referenced this pull request Dec 16, 2022
## Summary

This PR unskips a test that was skipped during the [Jest
upgrade](elastic#143319) to version 29.

Fixes elastic#145751

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jest 29 upgrade skipped test - x-pack/plugins/stack_connectors/public/connector_types/stack/es_index/es_index_connector.test.tsx

5 participants