Skip to content

feat(slo): burn rate rule editor#147211

Merged
kdelemme merged 28 commits intoelastic:mainfrom
kdelemme:feat/burn-rate-rule-editor
Dec 13, 2022
Merged

feat(slo): burn rate rule editor#147211
kdelemme merged 28 commits intoelastic:mainfrom
kdelemme:feat/burn-rate-rule-editor

Conversation

@kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Dec 7, 2022

📝 Summary

Related to #145262

This PR creates the burn rate rule editor form, with the different components and validation required.

The LongWindowDuration component validates that the duration is at least 30minutes and no more than 24 hours or 1440 minutes.
When an SLO is selected and the longWindowDuration is changed, the component computes the max burn rate allowed as defined by slo_window_in_minutes / long_window_in_minutes.

This PR does not integrate the Editor with the Rule framework yet. To prevent this PR to grow too much, I'll do the integration in a followup PR.

Status Screenshot
Error image
Success image
Searching image

🥼 Testing

You can run yarn storybook observability to check the component.

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0 labels Dec 7, 2022
@kdelemme kdelemme self-assigned this Dec 8, 2022
@kdelemme kdelemme marked this pull request as ready for review December 8, 2022 14:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme requested a review from a team December 8, 2022 15:29
@kdelemme kdelemme force-pushed the feat/burn-rate-rule-editor branch from dde5e00 to 4a07e34 Compare December 8, 2022 19:02
@benakansara
Copy link
Contributor

  • Searching on "Select SLO" doesn't filter the list on user input.

Screenshot 2022-12-12 at 14 14 28

  • When I type . in "Burn rate threshold", the value clears out to 0. Is this expected behaviour?

@kdelemme
Copy link
Contributor Author

@benakansara

Searching on "Select SLO" doesn't filter the list on user input.

This one is tricky since the Storybook uses mocks for the hook, therefore whatever you type always returns the same data. We would need to test with real data when we create the rule but this will be done in another PR.

When I type . in "Burn rate threshold", the value clears out to 0. Is this expected behaviour?

Good catch, the value needed to be set as a string actually 😬

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdelemme kdelemme enabled auto-merge (squash) December 13, 2022 13:42
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 457 459 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 574 579 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 502.4KB 502.4KB -23.0B
Unknown metric groups

API count

id before after diff
observability 578 583 +5

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
observability 46 47 +1
osquery 109 115 +6
securitySolution 445 451 +6
total +21

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
observability 53 54 +1
osquery 110 117 +7
securitySolution 521 527 +6
total +22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kdelemme kdelemme merged commit 28841a1 into elastic:main Dec 13, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Dec 13, 2022
@kdelemme kdelemme deleted the feat/burn-rate-rule-editor branch December 13, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants