change file namespace type to multiple-isolated#147198
Merged
vadimkibana merged 4 commits intomainfrom Dec 13, 2022
Merged
Conversation
vadimkibana
added
backport
jloleysens
reviewed
Dec 7, 2022
| name: FILE_SO_TYPE, | ||
| hidden: true, | ||
| namespaceType: 'agnostic', | ||
| namespaceType: 'multiple-isolated', |
Contributor
There was a problem hiding this comment.
Reading the docs:
In other words, objects with a "multiple-isolated" namespace type will be share-capable
I guess that means that are not shareable right now? CC @rudolf
Contributor
There was a problem hiding this comment.
Correct. The security team has docs on what needs to be done to make a multiple-isolated saved object shareable.
Contributor
Author
|
@elasticmachine merge upstream |
rudolf
approved these changes
Dec 12, 2022
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Dosant
approved these changes
Dec 13, 2022
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2022
## Summary Changes file saved object namespace to `multiple-isolated`. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0aa6e1c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2022
) # Backport This will backport the following commits from `main` to `8.6`: - [change file namespace type to multiple-isolated (#147198)](#147198) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vadim Kibana","email":"82822460+vadimkibana@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-12-13T13:24:40Z","message":"change file namespace type to multiple-isolated (#147198)\n\n## Summary\r\n\r\nChanges file saved object namespace to `multiple-isolated`.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0aa6e1c398ee5945bb9f9dd250dc6f19fad9f561","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","auto-backport","v8.6.0","v8.7.0","v8.6.1"],"number":147198,"url":"https://github.com/elastic/kibana/pull/147198","mergeCommit":{"message":"change file namespace type to multiple-isolated (#147198)\n\n## Summary\r\n\r\nChanges file saved object namespace to `multiple-isolated`.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0aa6e1c398ee5945bb9f9dd250dc6f19fad9f561"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147198","number":147198,"mergeCommit":{"message":"change file namespace type to multiple-isolated (#147198)\n\n## Summary\r\n\r\nChanges file saved object namespace to `multiple-isolated`.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0aa6e1c398ee5945bb9f9dd250dc6f19fad9f561"}}]}] BACKPORT--> Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes file saved object namespace to
multiple-isolated.