Skip to content

[Flaky Test] Fixes Space Navigation Race Condition #147193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeramysoucy merged 3 commits into from
Dec 13, 2022
Merged

[Flaky Test] Fixes Space Navigation Race Condition #147193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32a613d
Attempts to confirm space item click by checking the menu is no longe…
jeramysoucy Dec 7, 2022
4a469cf
Merge branch 'main' into fixes-flaky-spaces-nav-test
jeramysoucy Dec 8, 2022
2b5578c
Merge branch 'main' into fixes-flaky-spaces-nav-test
jeramysoucy Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/test/functional/page_objects/space_selector_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ export class SpaceSelectorPageObject extends FtrService {
this.log.info(`SpaceSelectorPage:goToSpecificSpace(${spaceId})`);
await this.testSubjects.click(`${spaceId}-selectableSpaceItem`);
await this.common.sleep(1000);
Copy link
Copy Markdown
Contributor

@thomheymann thomheymann Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this artificial timeout now that we're checking for the menu to be closed?

Copy link
Copy Markdown
Contributor Author

@jeramysoucy jeramysoucy Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was inclined to leave it in because there seems to sometimes be a delay between the click and the closing of the menu/redirect. Without it, it may be possible for another race condition resulting in the space item not even being there on the next retry.
If this doesn't solve the problem we were seeing, I think I will refactor the test to be as deterministic as possible, in which case we can take out the delay.

expect(await this.find.existsByCssSelector('#headerSpacesMenuContent')).to.be(false);
});
}

Expand Down