[TSVB] Change allowJs setting to true#147176
Merged
stratoula merged 6 commits intoelastic:mainfrom Dec 13, 2022
Merged
Conversation
stratoula
added
Feature:TSVB
stratoula
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
stratoula
changed the title
dej611
reviewed
Dec 12, 2022
...plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/sibling_buckets.ts
Outdated
Show resolved
Hide resolved
…rocessors/table/sibling_buckets.ts Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@dej611 do you want any other change? |
dej611
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #144284
This PR sets the
allowJsto true and solves the TS problems.