Skip to content

[Osquery] [Fix] Fix osquery results table fullscreen height issue #147076

Merged
tomsonpl merged 3 commits intoelastic:mainfrom
tomsonpl:fix-osquery-fullscreen-height
Dec 12, 2022
Merged

[Osquery] [Fix] Fix osquery results table fullscreen height issue #147076
tomsonpl merged 3 commits intoelastic:mainfrom
tomsonpl:fix-osquery-fullscreen-height

Conversation

@tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Dec 6, 2022

Fixed issue with result tab in fullscreen mode, while still preserve max-height for normal result tab (non-fullscreen).

Zrzut ekranu 2022-12-6 o 10 54 25

Zrzut ekranu 2022-12-6 o 10 54 30

@tomsonpl tomsonpl added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature v8.7.0 v8.6.1 labels Dec 6, 2022
@tomsonpl tomsonpl requested a review from a team as a code owner December 6, 2022 09:57
@tomsonpl tomsonpl self-assigned this Dec 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@tomsonpl
Copy link
Contributor Author

@elasticmachine merge upstream

@tomsonpl
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1022.7KB 1022.7KB +32.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 12, 2022
…ue (#147076) (#147381)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Osquery] [Fix] Fix osquery results table fullscreen height issue
(#147076)](#147076)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"tomasz.ciecierski@elastic.co"},"sourceCommit":{"committedDate":"2022-12-12T18:18:09Z","message":"[Osquery]
[Fix] Fix osquery results table fullscreen height issue
(#147076)","sha":"5d0855a08f9882b82f544ea01dc9325ff9a0f87b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Asset
Management","Feature:Osquery","v8.6.0","v8.7.0"],"number":147076,"url":"https://github.com/elastic/kibana/pull/147076","mergeCommit":{"message":"[Osquery]
[Fix] Fix osquery results table fullscreen height issue
(#147076)","sha":"5d0855a08f9882b82f544ea01dc9325ff9a0f87b"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147076","number":147076,"mergeCommit":{"message":"[Osquery]
[Fix] Fix osquery results table fullscreen height issue
(#147076)","sha":"5d0855a08f9882b82f544ea01dc9325ff9a0f87b"}}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Osquery Security Solution Osquery feature release_note:fix Team:Asset Management Security Asset Management Team v8.6.0 v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants