[8.6] quick check of current URL to skip timepicker (#146462)#146954
Merged
kibanamachine merged 1 commit intoelastic:8.6from Dec 4, 2022
Merged
[8.6] quick check of current URL to skip timepicker (#146462)#146954kibanamachine merged 1 commit intoelastic:8.6from
kibanamachine merged 1 commit intoelastic:8.6from
Conversation
## Summary We have some tests which set the default time but then also call setAbsoluteTime in every test. This PR adds code in setAbsoluteTime to quickly check if the desired start and end (from and to) times are already set, and if so, just return. The end result should be less time spent on functional tests. It could also reduce occasional flakiness setting the time. Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> (cherry picked from commit 1734b0e)
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation