Skip to content

[Security Solution] Failed to Fetch Rules and Timeline in Preview Flyout #146904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e40pud merged 1 commit into from
Dec 2, 2022
Merged

[Security Solution] Failed to Fetch Rules and Timeline in Preview Flyout #146904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions x-pack/plugins/security_solution/public/detection_engine/rule_management/logic/use_rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,17 @@ import * as i18n from './translations';
* @param id desired Rule ID's (not rule_id)
*
*/
export const useRule = (id: string) => {
export const useRule = (id: string, showToast = true) => {
const { addError } = useAppToasts();

return useFetchRuleByIdQuery(id, {
onError: (error) => {
addError(error, { title: i18n.RULE_AND_TIMELINE_FETCH_FAILURE });
},
});
return useFetchRuleByIdQuery(
id,
showToast
? {
onError: (error) => {
addError(error, { title: i18n.RULE_AND_TIMELINE_FETCH_FAILURE });
},
}
: undefined
);
};
2 changes: 1 addition & 1 deletion ...security_solution/public/detection_engine/rule_management/logic/use_rule_with_fallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const buildLastAlertQuery = (ruleId: string) => ({
* In that case, try to fetch the latest alert generated by the rule and retrieve the rule data from the alert (fallback).
*/
export const useRuleWithFallback = (ruleId: string): UseRuleWithFallback => {
const { isLoading: ruleLoading, data: ruleData, error, refetch } = useRule(ruleId);
const { isLoading: ruleLoading, data: ruleData, error, refetch } = useRule(ruleId, false);
const { addError } = useAppToasts();

const isExistingRule = !isNotFoundError(error);
Expand Down