[flot-charts] move into ui/public#14669
Merged
Merged
Conversation
Contributor
|
In the short-term I think this makes sense. For new platform |
Contributor
|
(but that's a problem we can solve later, when we start working on the ui parts of the new platform, so I'm good with merging this change for now, so we get rid of the |
spalger
force-pushed
the
move-flot-charts
branch
from
5a381ff to
b024dc5
Compare
Merged
kimjoar
approved these changes
Oct 30, 2017
spalger
added a commit
that referenced
this pull request
Oct 30, 2017
(cherry picked from commit 3e08a7e)
Contributor
Author
|
6.x: 79fdf95 |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14366 added a
flot-chartspackage to the packages directory, which was created for storing npm modules that we wanted to share git history with. Rather than publish the package to NPM though, the package is imported into the UI with a newpackages/alias, which I feel violates the intended purpose of the packages directory.This PR move the flot fork into
ui/public/flot-chartsso that it can be imported easily:Please let me know if you would prefer something else.