[Dashboard][Lens] Add "convert to lens" action to dashboard by VladLasitsa · Pull Request #146363 · elastic/kibana

VladLasitsa · 2022-11-28T09:16:07Z

Summary

Closes #147032
Completes part of: #144605

Added convert to lens action for panel in dashboards.

If legacy visualization can be converted, the notification 'dot' will shown on context menu.

New action looks like this:

After clicking by that action user will be navigate to lens page and see the following, where user can replace legacy visualization to lens on dashboard:

On save user also can replace panel on dashboard:

elasticmachine · 2022-12-02T09:03:00Z

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

elasticmachine · 2022-12-02T09:03:03Z

Pinging @elastic/kibana-presentation (Team:Presentation)

VladLasitsa · 2022-12-02T09:04:14Z

@elasticmachine merge upstream

stratoula · 2022-12-08T12:29:04Z

For click action, but maybe also the other one is also a good metric.

VladLasitsa · 2022-12-08T14:20:22Z

@VladLasitsa, I've looked through your proposed solution to the Canvas saved Object ID bug, and I think it will work great with one small change:

I think it needs to match the Dashboard incoming embeddable implementation, where if the type is different, we don't spread any of the originalInput at all. If you're comfortable with making that fix in the Canvas app, feel free to do so and I'll re-review. Otherwise, we can leave this as a bug for now and fix it on our side!

@ThomThomson, Put this fix in that PR.

VladLasitsa · 2022-12-08T14:20:41Z

@MichaelMarcialis do we want it first or second?

@stratoula, @VladLasitsa: If possible, I'd like the convert action to appear second, after the edit action.

@MichaelMarcialis, Done

VladLasitsa · 2022-12-08T14:20:58Z

For click action, but maybe also the other one is also a good metric.

@stratoula, Added for click only for now

ThomThomson

Looked through again, and everything LGTM! One nit is that it would be nice to have a comment explaining the hidePanelTitles change when dealing with the dashboard incoming embeddable. Really cool feature!

ThomThomson · 2022-12-08T15:17:47Z

x-pack/plugins/canvas/public/components/hooks/workpad/use_incoming_embeddable.ts

+        if (originalType !== type) {
+          updatedInput = incomingInput;
+        } else {
+          updatedInput = { ...originalInput, ...incomingInput };


Thank you for adding this fix! Now we can close this issue when this PR merges.

#147032

VladLasitsa · 2022-12-08T16:12:10Z

@elasticmachine merge upstream

VladLasitsa · 2022-12-12T08:18:21Z

@elasticmachine merge upstream

stratoula

I am super excited about this feature 😍
LGTM, I tested it both in Canvas and Dashboard and works great! Thanx Vlad

VladLasitsa · 2022-12-12T09:48:55Z

@MichaelMarcialis, Could you please review again?

VladLasitsa · 2022-12-12T09:49:38Z

@elastic/kibana-global-experience Could you please review?

clintandrewhall

Our code owners changes appear minimal. LGTM!

MichaelMarcialis

Thanks for making those changes, @VladLasitsa! This looks great! I've added two minor comments below, but approving now under the assumption that they can be addressed.

When converting a by-reference visualization to Lens, can the breadcrumb reference to the saved object name be contained in quotes? My previous comment to remove the quotes in the breadcrumbs was only meant to apply when converting by-value visualizations without a panel title (where we use the visualization type instead of a name, which doesn't need the quotations).

After saving a converted visualization to the library in Lens and choosing NOT to replace the panel on dashboard, users are now given the option to "Save and return" with a checkInCircleFilled icon. Per my earlier comments, can you change the text to "Save and replace" with a save icon instead?

…_dashboard

VladLasitsa · 2022-12-13T10:21:36Z

Thanks for making those changes, @VladLasitsa! This looks great! I've added two minor comments below, but approving now under the assumption that they can be addressed.

When converting a by-reference visualization to Lens, can the breadcrumb reference to the saved object name be contained in quotes? My previous comment to remove the quotes in the breadcrumbs was only meant to apply when converting by-value visualizations without a panel title (where we use the visualization type instead of a name, which doesn't need the quotations).

After saving a converted visualization to the library in Lens and choosing NOT to replace the panel on dashboard, users are now given the option to "Save and return" with a checkInCircleFilled icon. Per my earlier comments, can you change the text to "Save and replace" with a save icon instead?

@MichaelMarcialis thank you, Fixed these small nits

kibana-ci · 2022-12-13T13:32:06Z

💚 Build Succeeded

Buildkite Build
Commit: 705101f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	889	890	+1
`visualizations`	329	330	+1
total			+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visualizations`	767	770	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.0MB	1.0MB	+45.0B
`dashboard`	404.1KB	404.2KB	+49.0B
`lens`	1.3MB	1.3MB	+2.7KB
`visualizations`	267.4KB	267.6KB	+153.0B
total			+2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`embeddable`	69.0KB	69.7KB	+736.0B
`lens`	29.8KB	30.5KB	+638.0B
`uiActions`	19.7KB	19.7KB	+91.0B
`visualizations`	53.8KB	56.5KB	+2.8KB
total			+4.2KB

Unknown metric groups

API count

id	before	after	diff
`uiActions`	133	135	+2
`visualizations`	797	800	+3
total			+5

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	60	66	+6
`osquery`	109	115	+6
`securitySolution`	445	451	+6
total			+20

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	69	75	+6
`osquery`	110	117	+7
`securitySolution`	521	527	+6
total			+21

History

💔 Build #94288 failed 1d260b1
💔 Build #94263 failed ed576bd
💚 Build #93908 succeeded 1489189
💚 Build #93664 succeeded 135b36d
💔 Build #93622 failed a5447b4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

## Summary - #148331: [Updated screenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html) - #146335: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data) - #146363: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels) - #144867: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)

## Summary - elastic#148331: [Updated screenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html) - elastic#146335: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data) - elastic#146363: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels) - elastic#144867: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls) (cherry picked from commit e57883f)

## Summary - elastic#148331: [Updated screenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html) - elastic#146335: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data) - elastic#146363: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels) - elastic#144867: [Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)

Add "convert to lens" action to dashboard

7df2590

VladLasitsa self-assigned this Nov 28, 2022

VladLasitsa added 3 commits November 28, 2022 14:58

Fix CI

1b00b5e

Fix more tests

0fca07e

Fix test

f78d79b

VladLasitsa changed the title ~~[DASHBOARD][LENS] Add "convert to lens" action to dashboard~~ [Dashboard][Lens] Add "convert to lens" action to dashboard Nov 29, 2022

VladLasitsa added 2 commits November 29, 2022 13:22

Some improvments

8676538

Add functional tests

fe7c5cd

VladLasitsa marked this pull request as ready for review December 2, 2022 09:02

VladLasitsa requested review from a team as code owners December 2, 2022 09:02

kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// label Dec 2, 2022

VladLasitsa requested a review from stratoula December 2, 2022 09:03

VladLasitsa added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Dec 2, 2022

Merge branch 'main' into convert_to_lens_for_dashboard

efe7d80

botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 2, 2022

Some fixes

54161f8

Fix mocks

a5447b4

ThomThomson approved these changes Dec 8, 2022

View reviewed changes

Merge branch 'main' into convert_to_lens_for_dashboard

135b36d

Merge branch 'main' into convert_to_lens_for_dashboard

1489189

stratoula approved these changes Dec 12, 2022

View reviewed changes

clintandrewhall approved these changes Dec 12, 2022

View reviewed changes

MichaelMarcialis approved these changes Dec 12, 2022

View reviewed changes

VladLasitsa added 2 commits December 13, 2022 12:19

Fix small nits

9b35aa5

Merge remote-tracking branch 'upstream/main' into convert_to_lens_for…

ed576bd

…_dashboard

VladLasitsa added 2 commits December 13, 2022 13:25

fix test

1d260b1

Get correct title for replace action

705101f

VladLasitsa merged commit a068b2e into elastic:main Dec 13, 2022

KOTungseth mentioned this pull request Feb 21, 2023

[DOCS] 8.7 Presentation docs #151797

Merged

Conversation

VladLasitsa commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Dec 2, 2022

Uh oh!

elasticmachine commented Dec 2, 2022

Uh oh!

VladLasitsa commented Dec 2, 2022

Uh oh!

stratoula commented Dec 8, 2022

Uh oh!

VladLasitsa commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VladLasitsa commented Dec 8, 2022

Uh oh!

VladLasitsa commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

VladLasitsa commented Dec 8, 2022

Uh oh!

VladLasitsa commented Dec 12, 2022

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

VladLasitsa commented Dec 12, 2022

Uh oh!

VladLasitsa commented Dec 12, 2022

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelMarcialis left a comment

Choose a reason for hiding this comment

Uh oh!

VladLasitsa commented Dec 13, 2022

Uh oh!

kibana-ci commented Dec 13, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

VladLasitsa commented Nov 28, 2022 •

edited

Loading

VladLasitsa commented Dec 8, 2022 •

edited

Loading

VladLasitsa commented Dec 8, 2022 •

edited

Loading