[8.6] [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (#145583)#146344
Merged
kibanamachine merged 1 commit into8.6from Nov 25, 2022
Merged
Conversation
… with adhoc data views (#145583) ## Summary Fixes #141812 This PR preventing using Discover saved objects with adhoc data views in aggregation based visualisations. ### Test notes - Create Saved search based on adhoc data view in Discover - Open new Agg based visualisations list and choose one - Created Saved search shouldn't appear in the list. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2c9043a)
Merged
1 task
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Saved Objects .kibana field count
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @dimaanj |
dimaanj
added a commit
that referenced
this pull request
Nov 28, 2022
…bjects with adhoc data views (#145583) (#146412) # Backport This will backport the following commits from `main` to `8.5`: - [[Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (#145583)](#145583) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitry Tomashevich","email":"39378793+dimaanj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-25T13:16:34Z","message":"[Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (#145583)\n\n## Summary\r\n\r\nFixes #141812\r\n\r\nThis PR preventing using Discover saved objects with adhoc data views in\r\naggregation based visualisations.\r\n\r\n### Test notes \r\n- Create Saved search based on adhoc data view in Discover\r\n- Open new Agg based visualisations list and choose one\r\n- Created Saved search shouldn't appear in the list. \r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2c9043ab431cebbbdeb77c96aa2a5c0bc5b0ddf4","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Feature:Vis Editor","auto-backport","Team:DataDiscovery","v8.6.0","v8.7.0","v8.5.2"],"number":145583,"url":"https://github.com/elastic/kibana/pull/145583","mergeCommit":{"message":"[Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (#145583)\n\n## Summary\r\n\r\nFixes #141812\r\n\r\nThis PR preventing using Discover saved objects with adhoc data views in\r\naggregation based visualisations.\r\n\r\n### Test notes \r\n- Create Saved search based on adhoc data view in Discover\r\n- Open new Agg based visualisations list and choose one\r\n- Created Saved search shouldn't appear in the list. \r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2c9043ab431cebbbdeb77c96aa2a5c0bc5b0ddf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/146344","number":146344,"state":"MERGED","mergeCommit":{"sha":"461c04ec6cf855ba590b06d5be7ba121cefc00ba","message":"[8.6] [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (#145583) (#146344)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.6`:\n- [[Discover] Prevent agg based visualizations of Discover saved objects\nwith adhoc data views\n(#145583)](https://github.com/elastic/kibana/pull/145583)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dmitry\nTomashevich\",\"email\":\"39378793+dimaanj@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2022-11-25T13:16:34Z\",\"message\":\"[Discover]\nPrevent agg based visualizations of Discover saved objects with adhoc\ndata views (#145583)\\n\\n## Summary\\r\\n\\r\\nFixes #141812\\r\\n\\r\\nThis PR\npreventing using Discover saved objects with adhoc data views\nin\\r\\naggregation based visualisations.\\r\\n\\r\\n### Test notes \\r\\n-\nCreate Saved search based on adhoc data view in Discover\\r\\n- Open new\nAgg based visualisations list and choose one\\r\\n- Created Saved search\nshouldn't appear in the list. \\r\\n\\r\\n### Checklist\\r\\n\\r\\n\\r\\n- [ ]\n[Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"2c9043ab431cebbbdeb77c96aa2a5c0bc5b0ddf4\",\"branchLabelMapping\":{\"^v8.7.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Feature:Discover\",\"release_note:fix\",\"Feature:Vis\nEditor\",\"auto-backport\",\"Team:DataDiscovery\",\"v8.6.0\",\"v8.7.0\",\"v8.5.2\"],\"number\":145583,\"url\":\"https://github.com/elastic/kibana/pull/145583\",\"mergeCommit\":{\"message\":\"[Discover]\nPrevent agg based visualizations of Discover saved objects with adhoc\ndata views (#145583)\\n\\n## Summary\\r\\n\\r\\nFixes #141812\\r\\n\\r\\nThis PR\npreventing using Discover saved objects with adhoc data views\nin\\r\\naggregation based visualisations.\\r\\n\\r\\n### Test notes \\r\\n-\nCreate Saved search based on adhoc data view in Discover\\r\\n- Open new\nAgg based visualisations list and choose one\\r\\n- Created Saved search\nshouldn't appear in the list. \\r\\n\\r\\n### Checklist\\r\\n\\r\\n\\r\\n- [ ]\n[Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"2c9043ab431cebbbdeb77c96aa2a5c0bc5b0ddf4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.6\",\"8.5\"],\"targetPullRequestStates\":[{\"branch\":\"8.6\",\"label\":\"v8.6.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.7.0\",\"labelRegex\":\"^v8.7.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/145583\",\"number\":145583,\"mergeCommit\":{\"message\":\"[Discover]\nPrevent agg based visualizations of Discover saved objects with adhoc\ndata views (#145583)\\n\\n## Summary\\r\\n\\r\\nFixes #141812\\r\\n\\r\\nThis PR\npreventing using Discover saved objects with adhoc data views\nin\\r\\naggregation based visualisations.\\r\\n\\r\\n### Test notes \\r\\n-\nCreate Saved search based on adhoc data view in Discover\\r\\n- Open new\nAgg based visualisations list and choose one\\r\\n- Created Saved search\nshouldn't appear in the list. \\r\\n\\r\\n### Checklist\\r\\n\\r\\n\\r\\n- [ ]\n[Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"2c9043ab431cebbbdeb77c96aa2a5c0bc5b0ddf4\"}},{\"branch\":\"8.5\",\"label\":\"v8.5.2\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dmitry Tomashevich <39378793+dimaanj@users.noreply.github.com>"}},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145583","number":145583,"mergeCommit":{"message":"[Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (#145583)\n\n## Summary\r\n\r\nFixes #141812\r\n\r\nThis PR preventing using Discover saved objects with adhoc data views in\r\naggregation based visualisations.\r\n\r\n### Test notes \r\n- Create Saved search based on adhoc data view in Discover\r\n- Open new Agg based visualisations list and choose one\r\n- Created Saved search shouldn't appear in the list. \r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2c9043ab431cebbbdeb77c96aa2a5c0bc5b0ddf4"}},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation