-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Cases] Save draft user comment #146327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
js-jankisalvi
merged 50 commits into
elastic:main
from
js-jankisalvi:save-draft-user-cmment
Dec 14, 2022
Merged
[Cases] Save draft user comment #146327
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
d121368
feat: store draft description and comment
js-jankisalvi 58925e1
feat: save draft comments to session storage using storage kibana utils
js-jankisalvi 5701728
Merge remote-tracking branch 'upstream/main' into save-draft-user-cmment
js-jankisalvi cffe533
feat: added unit test and e2e UI tests
js-jankisalvi 21f7e8b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 9c88803
feat: added debounce, unit tests for draft comments
js-jankisalvi 080decf
Merge branch 'save-draft-user-cmment' of https://github.com/js-jankis…
js-jankisalvi 06c2da9
fixed conflict issue
js-jankisalvi ffbab09
fix: show version conflict error when user is editing a comment which…
js-jankisalvi 5374a93
fix: update error message
js-jankisalvi 66e3837
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 8759595
test description updated
js-jankisalvi 9e7d3e6
add constant for debounce time
js-jankisalvi 8553dc5
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi d20b100
fix: remove empty keys from session storage, prevent empty key on fir…
js-jankisalvi 20dfeae
Merge branch 'save-draft-user-cmment' of https://github.com/js-jankis…
js-jankisalvi 04942ae
fix: show version conflict warning instead of error
js-jankisalvi 7e29808
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi 8c26008
Merge branch 'main' into save-draft-user-cmment
kibanamachine 9c68478
fix: create a hook to add draft comments to session storage, save des…
js-jankisalvi d97471d
fix: removed console logs
js-jankisalvi 1f630e8
Merge remote-tracking branch 'upstream/main' into save-draft-user-cmment
js-jankisalvi 02f076d
conflicts resolved
js-jankisalvi a75e768
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 51b00aa
fix: remove mock values from jest
js-jankisalvi 2a20281
Merge branch 'save-draft-user-cmment' of https://github.com/js-jankis…
js-jankisalvi ac7a777
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi 15a273f
fix linting
js-jankisalvi 92b7a60
Merge branch 'save-draft-user-cmment' of https://github.com/js-jankis…
js-jankisalvi e01c9fc
lint fix
js-jankisalvi 7f25d73
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi 2b70e7f
Fix FTR e2e test fail on CI pipeline
js-jankisalvi 29f1a70
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine d738484
fix: add single case addition and deletion to draft comments describe
js-jankisalvi f6bbdb9
Fix: added unit tests for more scenarios
js-jankisalvi e2b4cc6
Merge remote-tracking branch 'upstream/main' into save-draft-user-cmment
js-jankisalvi a2dc3a3
prevent useSessionStorage hook to JSON serialize stored values
js-jankisalvi d848b17
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi 9775b94
fix: type check fixed for form_context
js-jankisalvi 1a1d54f
remove session storage key after each test
js-jankisalvi 6a39c82
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine acbcdfe
fix: add existing storage key test case, weird issue of comment stays…
js-jankisalvi 8781fcf
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi cbfb2c6
typos fixed
js-jankisalvi 4879bc1
Merge branch 'save-draft-user-cmment' of https://github.com/js-jankis…
js-jankisalvi 99c71cd
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi ee3d6f9
Merge branch 'main' into save-draft-user-cmment
js-jankisalvi 426ab55
fix
js-jankisalvi 520e3c5
Merge branch 'main' into save-draft-user-cmment
kibanamachine 4de1551
fix: description text updated, isFristrender check removed from debou…
js-jankisalvi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.